New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-3970. Enabling TestStorageContainerManager with all failures add… #1257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prashantpogde for working on this.
...zone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
Show resolved
Hide resolved
@@ -593,7 +591,7 @@ public void testCloseContainerCommandOnRestart() throws Exception { | |||
new TestStorageContainerManagerHelper(cluster, conf); | |||
|
|||
helper.createKeys(10, 4096); | |||
Thread.sleep(5000); | |||
Thread.sleep(10000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeated check (eg. GenericTestUtils.waitFor
) should be preferred over fixed length sleep:
- allow quicker test execution if possible
- explicit condition documents what the test is waiting for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. What about the other sleep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent some time looking around in the code. Not sure how we can do this cleanly for the other sleep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to ->
- waiting till the replication manager comes up using GenericTestUtils.waitFor and then
- wait some more to give it enough time to process containers
...zone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
Outdated
Show resolved
Hide resolved
...zone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
Outdated
Show resolved
Hide resolved
...zone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
Outdated
Show resolved
Hide resolved
Unrelated failure with coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prashantpogde for updating the patch. 20/20 runs passed twice.
* master: (55 commits) HDDS-4052. Remove master/slave terminology from Ozone (apache#1281) HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277) HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223) HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273) HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257) HDDS-4033. Make the acceptance test reports hierarchical (apache#1263) HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260) HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265) HDDS-4024. Avoid while loop too soon when exception happen (apache#1253) HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081) HDDS-4019. Show the storageDir while need init om or scm (apache#1248) HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247) HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267) HDDS-4031. Run shell tests in CI (apache#1261) HDDS-4038. Eliminate GitHub check warnings (apache#1268) HDDS-4011. Update S3 related documentation. (apache#1245) HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259) HDDS-4032. Run author check without docker (apache#1262) HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256) HDDS-4017. Acceptance check may run against wrong commit (apache#1249) ...
What changes were proposed in this pull request?
ContainerStateManager: Addressing test failures
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3970
How was this patch tested?
Testing TestStorageContainerManager several times in a row for failures.