Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4047. OzoneManager met NPE exception while getServiceList #1277

Merged
merged 2 commits into from Jul 30, 2020

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

OzoneManager met NPE exception while getServiceList after just startup.

What is the link to the Apache JIRA

HDDS-4047

How was this patch tested?

start om never see NPE again while getServiceList

@maobaolong
Copy link
Member Author

This has been test locally.

@maobaolong maobaolong closed this Jul 30, 2020
@maobaolong maobaolong reopened this Jul 30, 2020
Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maobaolong for reporting the issue and propose the fix. There is a small window between RPC server start and the http server start when the getServiceList is called can trigger this.

The PR LGTM, +1 pending CI.

@xiaoyuyao xiaoyuyao merged commit a95b0b8 into apache:master Jul 30, 2020
xiaoyuyao pushed a commit that referenced this pull request Jul 30, 2020
@maobaolong
Copy link
Member Author

@xiaoyuyao Thanks for your review and merge this for me.

errose28 pushed a commit to errose28/ozone that referenced this pull request Jul 31, 2020
* master: (55 commits)
  HDDS-4052. Remove master/slave terminology from Ozone (apache#1281)
  HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277)
  HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223)
  HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273)
  HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257)
  HDDS-4033. Make the acceptance test reports hierarchical (apache#1263)
  HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260)
  HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265)
  HDDS-4024. Avoid while loop too soon when exception happen (apache#1253)
  HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081)
  HDDS-4019. Show the storageDir while need init om or scm (apache#1248)
  HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247)
  HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267)
  HDDS-4031. Run shell tests in CI (apache#1261)
  HDDS-4038. Eliminate GitHub check warnings (apache#1268)
  HDDS-4011. Update S3 related documentation. (apache#1245)
  HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259)
  HDDS-4032. Run author check without docker (apache#1262)
  HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256)
  HDDS-4017. Acceptance check may run against wrong commit (apache#1249)
  ...
vivekratnavel pushed a commit to vivekratnavel/hadoop-ozone that referenced this pull request Aug 8, 2020
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants