HDDS-2656. Prefer execute() over submit() if the returned Future is ignored #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The acceptance tests all pass, but for some reason the script is returning a non-zero result. I am going to commit this patch. |
|
Thanks @anuengineer for committing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Future submit(Runnable)andvoid execute(Runnable)inExecutorServicehave the same result. If the returnedFutureis ignored,executecan be used instead ofsubmitto avoid creating some objects.https://issues.apache.org/jira/browse/HDDS-2656
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/333081135