Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-2752. Unnecessary calls to isNoneEmpty and isAllEmpty #364

Merged
merged 1 commit into from
Dec 16, 2019
Merged

HDDS-2752. Unnecessary calls to isNoneEmpty and isAllEmpty #364

merged 1 commit into from
Dec 16, 2019

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Replace isNoneEmpty and isAllEmpty with isNotEmpty and isEmpty for single string invocations to avoid varargs.

https://issues.apache.org/jira/browse/HDDS-2752

How was this patch tested?

TestAuthorizationHeaderV4 unit test.

https://github.com/adoroszlai/hadoop-ozone/runs/350168306

@xiaoyuyao
Copy link
Contributor

LGTM, +1.

@xiaoyuyao xiaoyuyao merged commit 2a91bb6 into apache:master Dec 16, 2019
@adoroszlai adoroszlai deleted the HDDS-2752 branch December 17, 2019 06:32
@adoroszlai
Copy link
Contributor Author

Thanks @xiaoyuyao for reviewing and merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adoroszlai @xiaoyuyao