Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2134. OM Metrics graphs include empty request type #1451

Closed
wants to merge 1 commit into from

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Handle numVolumes, numBuckets, and numKeys metrics as "other", instead of including them in the Volume, Bucket, and Key request graphs.

https://issues.apache.org/jira/browse/HDDS-2134

How was this patch tested?

Checked OM Metrics after running freon. Verified that NumVolumes, etc. appear in the Other JMX properties table, and that the number of volme/bucket/key requests in the graphs add up to the total shown above each graph.

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Sep 16, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 1 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 32 hadoop-ozone in trunk failed.
-1 compile 22 hadoop-ozone in trunk failed.
+1 mvnsite 0 trunk passed
+1 shadedclient 876 branch has no errors when building and testing our client artifacts.
+1 javadoc 161 trunk passed
_ Patch Compile Tests _
-1 mvninstall 33 hadoop-ozone in the patch failed.
-1 jshint 80 The patch generated 1392 new + 2737 unchanged - 0 fixed = 4129 total (was 2737)
-1 compile 22 hadoop-ozone in the patch failed.
-1 javac 22 hadoop-ozone in the patch failed.
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 654 patch has no errors when building and testing our client artifacts.
+1 javadoc 156 the patch passed
_ Other Tests _
-1 unit 130 hadoop-hdds in the patch failed.
-1 unit 27 hadoop-ozone in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
2621
Reason Tests
Failed junit tests hadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.ozone.container.keyvalue.TestKeyValueContainer
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/Dockerfile
GITHUB PR #1451
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient jshint
uname Linux b765d740c005 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 85b1c72
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/branch-compile-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
jshint https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/diff-patch-jshint.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/patch-compile-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/testReport/
Max. process+thread count 446 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1451/1/console
versions git=2.7.4 maven=3.3.9 jshint=2.10.2
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai
Copy link
Contributor Author

@elek please review

@elek
Copy link
Member

elek commented Sep 16, 2019

/retest

1 similar comment
@adoroszlai
Copy link
Contributor Author

/retest

@elek elek closed this in 419dd0f Sep 18, 2019
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

Thanks. Tested and worked well.

@adoroszlai adoroszlai deleted the HDDS-2134 branch September 18, 2019 12:14
@adoroszlai
Copy link
Contributor Author

Thanks @elek for reviewing and committing it.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants