HADOOP-17482: Remove Commons Logger from FileSystem Class #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belugabehr
commented
Jan 20, 2021
...-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
Show resolved
Hide resolved
belugabehr
commented
Jan 20, 2021
...-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
Show resolved
Hide resolved
belugabehr
commented
Jan 20, 2021
| } | ||
| // and at debug: the full stack | ||
| LOG.debug("Stack Trace", ee); | ||
| LOGGER.warn("Cannot load filesystem", ee); |
There was a problem hiding this comment.
I'm not sure what the capability of Commons Logger is, but in SLF4J, the entire list of 'caused by' is printed so there is no need to do this manually when switching loggers, but this may also just be an oversight, I'm not sure.
There was a problem hiding this comment.
I think relying on slf4j and just dumping the whole exception is good.
belugabehr
commented
Jan 20, 2021
Comment on lines
-103
to
-112
|
|
||
| { | ||
| try { | ||
| GenericTestUtils.setLogLevel(FileSystem.LOG, Level.DEBUG); | ||
| } | ||
| catch(Exception e) { | ||
| System.out.println("Cannot change log level\n" | ||
| + StringUtils.stringifyException(e)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not good practice to modify this manually. Should be using log4j properties files to set logging levels.
There was a problem hiding this comment.
its a test and they may have had some good reasons, just as some of the Azure tests do
There was a problem hiding this comment.
We need to fix it properly then. @belugabehr do you mind undoing this particular one in a separate JIRA or proposing the log4j solution?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Jan 27, 2021
|
@goiri Thanks so much for the approval. Are you also able to do the merge? It's been a little while for me regarding the process and I'd need to research what the current practice/process is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute