HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient #774
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nectionTimeout and readTimeout of HttpClient.
|
🎊 +1 overall
This message was automatically generated. |
| @@ -57,7 +64,14 @@ public URI getUri() { | |||
|
|
|||
| @Override | |||
| public FSDataInputStream open(Path path, int bufferSize) throws IOException { | |||
| int httpConnectTimeoutInMillis = conf.getInt(CONF_HTTP_CONNECT_TIMEOUT, DEFAULT_HTTP_CONNECT_TIMEOUT_IN_MILLIS); | |||
| int httpReadTimeoutInMillis = conf.getInt(CONF_HTTP_READ_TIMEOUT, DEFAULT_HTTP_READ_TIMEOUT_IN_MILLIS); | |||
| Preconditions.checkState(httpConnectTimeoutInMillis > 0, "Http connection timeout has to greater than zero."); | |||
There was a problem hiding this comment.
better:
"Invalid value of " + CONF_HTTP_CONNECT_TIMEOUT +": %d ", httpConnectTimeoutInMillis)
This lists the property name and the actual value set.
| int httpConnectTimeoutInMillis = conf.getInt(CONF_HTTP_CONNECT_TIMEOUT, DEFAULT_HTTP_CONNECT_TIMEOUT_IN_MILLIS); | ||
| int httpReadTimeoutInMillis = conf.getInt(CONF_HTTP_READ_TIMEOUT, DEFAULT_HTTP_READ_TIMEOUT_IN_MILLIS); | ||
| Preconditions.checkState(httpConnectTimeoutInMillis > 0, "Http connection timeout has to greater than zero."); | ||
| Preconditions.checkState(httpReadTimeoutInMillis > 0, "Http read timeout has to greater than zero."); |
| @@ -39,13 +40,19 @@ | |||
| abstract class AbstractHttpFileSystem extends FileSystem { | |||
| private static final long DEFAULT_BLOCK_SIZE = 4096; | |||
| private static final Path WORKING_DIR = new Path("/"); | |||
| private static final String CONF_HTTP_READ_TIMEOUT = "yarn.nodemanager.localizer.http.read.timeout.ms"; | |||
There was a problem hiding this comment.
- these should be somewhere where they can be referred to in code, such as a new class
HttpFileSystemConstants - And their name must be that of the filesystem class, not anything related to the RM.
|
|
||
| Configuration conf = new Configuration(false); | ||
| conf.set("fs.http.impl", HttpFileSystem.class.getCanonicalName()); | ||
| conf.set("yarn.nodemanager.localizer.http.connect.timeout.ms", "-1"); |
There was a problem hiding this comment.
use the values set in HttpFileSystemConstants
|
Code looks good, tests look great. Key comments
|
|
🎊 +1 overall
This message was automatically generated. |
|
Patch still has outstanding suggestions and checkstyle issues. Other than that I'm happy with it |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…sage __key__ to accept any format Author: Aditya Toomula <atoomula@linkedin.com> Reviewers: Srinivasulu Punuru <spunuru@linkedin.com> Closes apache#774 from atoomula/keyformat
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.