HBASE-20598 - Upgrade to JRuby 9.2 #2308

nkalmar · 2020-08-25T10:26:16Z

After upgrade, prompt changed (mainly what it prints as session name, used to be "main" now the hbase object instance name). We decided to change prompt to"%N:%03n>", %N being Irb.conf[:IRB_NAME] (hbase) and %03n the line number.

Add to docs:
For changelog please check https://www.jruby.org/news

Main changes:
JRuby 9.2.0 minor release:

Ruby 2.5 language and stdlib support
225 issues fixed

JRuby versions up to 9.2.13.0 had various bugfixes, security fixes, performance improvements (memory reduction, runtime generations), IO improvements, basic support for java11,

Main gems changes:

9.2.11.0: Gems and gem paths packaged inside jar files will properly load now. This 9.2.10.0 regression was caused by a change in RubyGems 3 that exposed a bug in JRuby
9.2.10.0: RubyGems has been updated to version 3.0.6.

No change in license

joshelser · 2020-09-10T15:06:42Z

It looks like unit tests are passing (per the last report). @nkalmar have you launched a local instance with HBase shell just to make sure basic operations still work (e.g. create a table, put some rows, scan the rows)?

Tentatively +1 on the above sanity check and unit tests

whoever takes this on: please doc supported ruby version changes, any changes to bundled gems, any license adjustments, and if/how the jruby community denotes "early access" vs "production ready" releases.

@busbey had also asked the above on Jira. I know that I'm always confused finding jruby docs, but can you try to get this list of changes together, Norbert?

nkalmar · 2020-09-16T16:27:32Z

Hi @joshelser , yes I did test shell on my local machine, but just for a sanity check, I tested again.

Built master with this commit on top (mvn clean install -DskipTests assembly:single)
start-hbase.sh / hbase shell and issue comands create/list/put/scan

I restarted the pre-commit job because it was flaky at the time, and I saw timeouts in the logs, and/or some dockr problems. No test failures or other errors though. Still, I couldn't get a clean build.

As for JRuby docs, this is what I written together, please let me know what is missing/should be changed. (We could list all the bugfixes, but it's more than a 1.000, and the below link has it all). Thanks!

For changelog please check https://www.jruby.org/news

Main points:
JRuby 9.2.0 minor release:

Ruby 2.5 language and stdlib support
225 issues fixed for 9.2.0.0

JRuby versions up to 9.2.13.0 had various bugfixes, seucirty fixes, performance improvements (memory reduction, runtime generations), IO improvements, basic support for java11,

Main gems changes:

9.2.11.0: Gems and gem paths packaged inside jar files will properly load now. This 9.2.10.0 regression was caused by a change in RubyGems 3 that exposed a bug in JRuby
9.2.10.0: RubyGems has been updated to version 3.0.6.

License did not change: "You can redistribute it and/or modify it under either the terms of the 2-clause BSDL (see the file BSDL)" in 9.1.17.0 and in master.
No commits was made to the license file either.

nkalmar · 2020-09-22T12:22:47Z

Rebased to current master

joshelser · 2020-09-22T17:36:24Z

Some subtle changes I'm noticing, the prompt is different. Now..

hbase(#<IRB::WorkSpace:0x27e44e9c>):003:0>

and before...

hbase(main):001:0>

Timestamps are also pretty-printed now:

ROW                                                                    COLUMN+CELL
 r1                                                                    column=f:q, timestamp=2020-09-22T13:33:56.089, value=value
1 row(s)
Took 0.1200 seconds

was before..

hbase(main):001:0> scan 'j1'
ROW                   COLUMN+CELL
 r1                   column=f:q, timestamp=1600796036089, value=value
1 row(s)
Took 0.3820 seconds

The timestamp one is probably something we should fix. I think the prompt fixing would be nice to fix, but I'm not sure how to do that without a deep dive :)

nkalmar · 2020-10-02T08:04:16Z

Hi @joshelser , I found why it is pretty printed. It is strange, because it is explicitly converted by this function:

def toLocalDateTime(millis)
      instant = java.time.Instant.ofEpochMilli(millis)
      return java.time.LocalDateTime.ofInstant(instant, java.time.ZoneId.systemDefault()).toString
    end

So I think it was meant to be pretty printed originally, but due to some bug it wasn't. I'll check the other places this function is called if it is/was pretty printed or not.

nkalmar · 2020-10-02T09:53:49Z

Isn't the pretty print because of HBASE-23930?

saintstack · 2020-10-06T01:39:17Z

@nkalmar yes, I think so.

Any luck w/ the prompt? Thanks.

joshelser · 2020-10-07T18:42:16Z

Isn't the pretty print because of HBASE-23930?

Aha! Right you are. Sorry for sending you on a goose-chase.

nkalmar · 2020-10-08T11:00:42Z

No, I couldn't find why session name changed unfortunately. I found some vague info that this prints top lvl class/instance. I think the solution is in hirb.rb class where we instantiate the prompt. I will take another go at it.

Or more like around here:
::IRB::WorkSpace.new(hbase_receiver.get_binding)

nkalmar · 2020-10-08T13:47:35Z

Cancel that, this is not working, this config not only changes session name but the object as well, it's no longer hbase but basically a "main" string... reverting

busbey · 2020-10-23T16:57:58Z

pom.xml

@@ -1633,8 +1633,8 @@
    <jamon-runtime.version>2.4.1</jamon-runtime.version>
    <jettison.version>1.3.8</jettison.version>
    <!--Make sure these joni/jcodings are compatible with the versions used by jruby-->
-    <joni.version>2.1.11</joni.version>
-    <jcodings.version>1.0.18</jcodings.version>
+    <joni.version>2.1.40</joni.version>


are these the versions that match what's in jruby-complete for 9.2.13.0?

No, that's 2.1.31. We should change to that?

Changed it.

Only certain versions of Joni and JCodings work together, so when they don't match what's in the jruby-complete jar you can get weird hard to diagnose runtime failures depending on the classpath ordering.

I have in my backlog filing a jira about making sure they match, so I think you'd be fine to skip it here if you want. (like if something goes wrong with the test run after changing it.)

Change-Id: I44d2f0d1b530c4018230460732aa6f478a22a474

Apache-HBase · 2020-10-27T14:04:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	7m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 4s	The patch generated 8 new + 24 unchanged - 1 fixed = 32 total (was 25)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	17m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		32m 39s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	dupname asflicense rubocop hadoopcheck xml
uname	Linux 494befc67d3e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `164cc5a`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: . hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-27T18:11:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 34s	master passed
+1 💚	compile	3m 4s	master passed
+1 💚	shadedjars	7m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 15s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	3m 4s	the patch passed
+1 💚	javac	3m 4s	the patch passed
+1 💚	shadedjars	7m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	239m 19s	root in the patch passed.
		279m 30s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7992fdbfaf0a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `164cc5a`
Default Java	2020-01-14
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/testReport/
Max. process+thread count	4813 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-27T19:41:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 43s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	2m 38s	master passed
+1 💚	shadedjars	7m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 24s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	2m 37s	the patch passed
+1 💚	javac	2m 37s	the patch passed
+1 💚	shadedjars	7m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	333m 18s	root in the patch failed.
		369m 32s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 33dc833b7e4d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `164cc5a`
Default Java	1.8.0_232
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/testReport/
Max. process+thread count	3108 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/16/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

nkalmar · 2020-10-28T10:00:08Z

Different test failed than before, restarting build

Apache-HBase · 2020-10-28T10:29:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 5s	The patch generated 8 new + 24 unchanged - 1 fixed = 32 total (was 25)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	18m 55s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		28m 50s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	dupname asflicense rubocop hadoopcheck xml
uname	Linux c55586a5f7fd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `17f9ade`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	62 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-28T14:40:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 41s	master passed
+1 💚	compile	3m 7s	master passed
+1 💚	shadedjars	7m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 20s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 30s	the patch passed
+1 💚	compile	3m 4s	the patch passed
+1 💚	javac	3m 4s	the patch passed
+1 💚	shadedjars	7m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	239m 28s	root in the patch passed.
		280m 10s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e279f6991b0e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `17f9ade`
Default Java	2020-01-14
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/testReport/
Max. process+thread count	4205 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-28T15:58:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 29s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	shadedjars	6m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	2m 17s	the patch passed
+1 💚	javac	2m 18s	the patch passed
+1 💚	shadedjars	6m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 18s	the patch passed
		_ Other Tests _
-1 ❌	unit	325m 7s	root in the patch failed.
		358m 19s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 913c8c02f2ae 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `17f9ade`
Default Java	1.8.0_232
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/testReport/
Max. process+thread count	6058 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/17/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

nkalmar · 2020-10-29T17:21:16Z

Why is this so flaky? Different 5 tests this time, only 1 test last time :(
All of them seems to be timeout issues.

Apache-HBase · 2020-10-29T17:49:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 4s	The patch generated 8 new + 24 unchanged - 1 fixed = 32 total (was 25)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	17m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		26m 33s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	dupname asflicense rubocop hadoopcheck xml
uname	Linux d65df110ab6c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `259fe19`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: . hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-29T20:47:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	2m 47s	master passed
+1 💚	shadedjars	6m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 54s	the patch passed
+1 💚	compile	2m 46s	the patch passed
+1 💚	javac	2m 46s	the patch passed
+1 💚	shadedjars	6m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	167m 33s	root in the patch passed.
		204m 44s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bf321ea0cd9e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `259fe19`
Default Java	2020-01-14
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/testReport/
Max. process+thread count	7441 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-29T22:46:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 42s	master passed
+1 💚	compile	2m 21s	master passed
+1 💚	shadedjars	6m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 16s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	2m 19s	the patch passed
+1 💚	javac	2m 19s	the patch passed
+1 💚	shadedjars	6m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 17s	the patch passed
		_ Other Tests _
-1 ❌	unit	290m 0s	root in the patch failed.
		323m 7s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 407a7366a9cc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `259fe19`
Default Java	1.8.0_232
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/testReport/
Max. process+thread count	4627 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/18/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-30T17:29:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 3s	The patch generated 8 new + 24 unchanged - 1 fixed = 32 total (was 25)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	17m 19s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		27m 0s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	dupname asflicense rubocop hadoopcheck xml
uname	Linux 35dae1195ced 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e3beccf`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-30T20:14:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 21s	master passed
+1 💚	compile	2m 48s	master passed
+1 💚	shadedjars	6m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 59s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	compile	2m 47s	the patch passed
+1 💚	javac	2m 47s	the patch passed
+1 💚	shadedjars	6m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	the patch passed
		_ Other Tests _
-1 ❌	unit	152m 37s	root in the patch failed.
		191m 5s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2bffc7f08aef 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e3beccf`
Default Java	2020-01-14
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/testReport/
Max. process+thread count	3709 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-30T23:16:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 4s	master passed
+1 💚	compile	2m 38s	master passed
+1 💚	shadedjars	7m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	2m 44s	the patch passed
+1 💚	javac	2m 44s	the patch passed
+1 💚	shadedjars	7m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	335m 28s	root in the patch failed.
		373m 11s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 43966682cadc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e3beccf`
Default Java	1.8.0_232
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/testReport/
Max. process+thread count	3097 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/19/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-09T16:40:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 38s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 5s	The patch generated 8 new + 24 unchanged - 1 fixed = 32 total (was 25)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	17m 22s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		26m 41s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/20/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	dupname asflicense rubocop hadoopcheck xml
uname	Linux c60b10396a97 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `58c9748`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/20/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/20/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-09T19:49:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	2m 48s	master passed
+1 💚	shadedjars	6m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	2m 45s	the patch passed
+1 💚	javac	2m 45s	the patch passed
+1 💚	shadedjars	6m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	178m 38s	root in the patch passed.
		216m 8s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/20/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2308
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 01191d0016a9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `58c9748`
Default Java	2020-01-14
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/20/testReport/
Max. process+thread count	7452 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2308/20/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

joshelser

Busbey just reminded me that I never clicked the +1 :) sorry, Norbert!

busbey

I think those test are flakey. I'm about done rebasing and check some thing locally and then I'll go forward with merging.

- upgrade our default jruby to 9.2.13.0 - this major JRuby version update changes the Ruby compatibility from Ruby 2.3 to Ruby 2.5 - use a custom IRB prompt to convey similar information to before - update the joni and jcoding dependencies to match this version of jruby-complete closes #2308 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit f0c430a)

- upgrade our default jruby to 9.2.13.0 - this major JRuby version update changes the Ruby compatibility from Ruby 2.3 to Ruby 2.5 - use a custom IRB prompt to convey similar information to before - update the joni and jcoding dependencies to match this version of jruby-complete closes apache#2308 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit f0c430a)

- upgrade our default jruby to 9.2.13.0 - this major JRuby version update changes the Ruby compatibility from Ruby 2.3 to Ruby 2.5 - use a custom IRB prompt to convey similar information to before - update the joni and jcoding dependencies to match this version of jruby-complete closes apache#2308 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit f0c430a) Change-Id: Ia006503ee723ed417a45f5ee25a76e9edf624fd1

- upgrade our default jruby to 9.2.13.0 - this major JRuby version update changes the Ruby compatibility from Ruby 2.3 to Ruby 2.5 - use a custom IRB prompt to convey similar information to before - update the joni and jcoding dependencies to match this version of jruby-complete closes apache#2308 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit f0c430a)

This comment has been minimized.

Sign in to view

nkalmar force-pushed the master branch from c1b6452 to e6458bb Compare September 22, 2020 12:22

This comment has been minimized.

Sign in to view

nkalmar force-pushed the master branch from 67b9f14 to e6458bb Compare October 8, 2020 13:55

This comment has been minimized.

Sign in to view

busbey reviewed Oct 23, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

HBASE-20598 - change joni version to match jruby complete

2dfd694

Change-Id: I44d2f0d1b530c4018230460732aa6f478a22a474

joshelser approved these changes Nov 9, 2020

View reviewed changes

busbey approved these changes Nov 9, 2020

View reviewed changes

asfgit closed this in f0c430a Nov 9, 2020

HBASE-20598 - Upgrade to JRuby 9.2 #2308

HBASE-20598 - Upgrade to JRuby 9.2 #2308

Conversation

nkalmar commented Aug 25, 2020 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshelser commented Sep 10, 2020

nkalmar commented Sep 16, 2020 • edited

nkalmar commented Sep 22, 2020

This comment has been minimized.

This comment has been minimized.

joshelser commented Sep 22, 2020

This comment has been minimized.

nkalmar commented Oct 2, 2020

nkalmar commented Oct 2, 2020

saintstack commented Oct 6, 2020

joshelser commented Oct 7, 2020

nkalmar commented Oct 8, 2020 • edited

nkalmar commented Oct 8, 2020 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

busbey Oct 23, 2020

Choose a reason for hiding this comment

nkalmar Oct 27, 2020

Choose a reason for hiding this comment

nkalmar Oct 27, 2020

Choose a reason for hiding this comment

busbey Oct 27, 2020

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Oct 27, 2020

Apache-HBase commented Oct 27, 2020

Apache-HBase commented Oct 27, 2020

nkalmar commented Oct 28, 2020

Apache-HBase commented Oct 28, 2020

Apache-HBase commented Oct 28, 2020

Apache-HBase commented Oct 28, 2020

nkalmar commented Oct 29, 2020 • edited

Apache-HBase commented Oct 29, 2020

Apache-HBase commented Oct 29, 2020

Apache-HBase commented Oct 29, 2020

Apache-HBase commented Oct 30, 2020

Apache-HBase commented Oct 30, 2020

Apache-HBase commented Oct 30, 2020

Apache-HBase commented Nov 9, 2020

Apache-HBase commented Nov 9, 2020

joshelser left a comment

Choose a reason for hiding this comment

busbey left a comment

Choose a reason for hiding this comment

nkalmar commented Aug 25, 2020 •

edited

nkalmar commented Sep 16, 2020 •

edited

nkalmar commented Oct 8, 2020 •

edited

nkalmar commented Oct 8, 2020 •

edited

nkalmar commented Oct 29, 2020 •

edited