HBASE-20162 [nightly] depending on pipeline execution we sometimes re… #74
Conversation
…fer to the wrong workspace
| @@ -101,7 +98,8 @@ if [ ! -d "${YETUS_DIR}" ]; then | |||
| gunzip -c yetus.tar.gz | tar xpf - -C "${YETUS_DIR}" --strip-components 1 | |||
| fi | |||
| ''' | |||
| dir ("${env.TOOLS}") { | |||
| // Set up the file we need at PERSONALITY_FILE location | |||
| dir ("tools") { | |||
There was a problem hiding this comment.
This will always be relative to root? To $BASEDIR?
There was a problem hiding this comment.
it's relative to the workspace root.
There was a problem hiding this comment.
at the end of this stage we stash the tools directory and in future stages we unstash it relative to those stages' workspace root.
| @@ -408,6 +410,9 @@ curl -L -o personality.sh "${env.PROJECT_PERSONALITY}" | |||
| // this needs to be set to the jdk that ought to be used to build releases on the branch the Jenkinsfile is stored in. | |||
| jdk "JDK 1.8 (latest)" | |||
| } | |||
| environment { | |||
| BASEDIR = "${env.WORKSPACE}/component" | |||
There was a problem hiding this comment.
What's the difference between ${BASEDIR} and ${env.BASEDIR} below
Do they both read this value, or does only env.BASEDIR read this and the other one comes from ~magic
There was a problem hiding this comment.
env.BASEDIR gets replaced with the literal value by jenkins. BASEDIR is a bash variable that will be set to a value of the same thing that Jenkins would rewrite.
There was a problem hiding this comment.
this one doesn't have a node? so where does it exec?
There was a problem hiding this comment.
stages that don't have their own node label exec on the same node as the task that launches the entire pipeline (so the one that runs the "install yetus" and "init health results" steps)
| @@ -130,6 +128,7 @@ curl -L -o personality.sh "${env.PROJECT_PERSONALITY}" | |||
| } | |||
| } | |||
| environment { | |||
| BASEDIR = "${env.WORKSPACE}/component" | |||
There was a problem hiding this comment.
I... don't understand how these are different from what we had previously?
There was a problem hiding this comment.
the captured context is different. jenkins captures things like WORKSPACE per executor. how it turns the given stages and initial environment into executors is magic AFAICT.
There was a problem hiding this comment.
so down here, because we had a node on the stage we get a new executor and a new WORKSPACE gets made.
|
ugh, lack of jira integration / notifications. |
HBASE-201 CVE-2016-6796: Tomcat / Jasper library vulnerability
…fer to the wrong workspace