-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-18901 [C++] Provide CMAKE infrastructure #64
Conversation
636524e
to
1cb9ef5
Compare
Note that some of the cmake modules are derivative of previous work that I've done, which was likely derivative work of someone else's work years past. How would you like me to handle this? Even if I didn't immediately reference or copy their cmake module I'd be happy to document somewhere that something may be a derivative work as a result of someone else's efforts that I've propagated via memory. |
c5a15c5
to
b36e896
Compare
* Provided cmake files for packages in which a default module did not exist. * Moved tests to a location where we could automatically build the test suite. * Resolved minor issues with tests * Tested across OSX, RHEL7, and Ubuntu16 HBASE-18901 [C++] Cleanup CMAKE JJELSER: A hack to get the protobuf-gen headers installed too. Admittedly, not sure if there is a better way to do it. HBASE-18901 [C++] Fix PROTOBUF_LIBRARY by removing static override in FindZookeeper HBASE-18901 [C++] Remove white space lines and clean up CMAKE
b36e896
to
5ed5927
Compare
This PR is slated to be closed as a part of HBASE-20391 because the referenced JIRA has since closed. If this is incorrect and you are still interested in working on the issue please comment there and/or reopen the PR. |
did not exist.
the test suite.
HBASE-18901 [C++] Cleanup CMAKE