HBASE-23707 Add IntelliJ check style plugin configuration

[ndimiduk]

No description provided.

[ndimiduk]

There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 28s	master passed
+1 💚	checkstyle	2m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 54s	the patch passed
+1 💚	checkstyle	2m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
		_ Other Tests _
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		16m 47s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/1/artifact/out/Dockerfile
GITHUB PR	#1064
Optional Tests	dupname asflicense checkstyle xml
uname	Linux 49ff86982143 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1064/out/precommit/personality/provided.sh
git revision	master / 70c8a5d
Max. process+thread count	96 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[jshiell]

There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?

I'm afraid not, and no plans to add it at present. There's no abstraction that IDEA provides for this, so we'd need to implement code for each build system - Maven at least is just XML, but Gradle is an entirely different kettle of fish. I won't even think about SBT ... 😄

[saintstack]

I tried the patch. Before applying, I was getting the below when I sync'd the checkstyle versions between hbase and intellij...

1/20/20
8:23 AM The Checkstyle rules file could not be parsed.
LineLength is not allowed as a child in Checker
The file has been blacklisted for 60s.

8:23 AM Unexpected Exception Caught
The scan failed due to an exception: Could not create checker
org.infernus.idea.checkstyle.exception.CheckStylePluginException: Could not create checker
at org.infernus.idea.checkstyle.checker.ScanFiles.lambda$checkFiles$8(ScanFiles.java:198)
at java.util.Optional.orElseThrow(Optional.java:290)
at org.infernus.idea.checkstyle.checker.ScanFiles.checkFiles(ScanFiles.java:198)
at org.infernus.idea.checkstyle.checker.ScanFiles.processFilesForModuleInfoAndScan(ScanFiles.java:156)
at org.infernus.idea.checkstyle.checker.ScanFiles.call(ScanFiles.java:78)
at org.infernus.idea.checkstyle.checker.ScanFiles.call(ScanFiles.java:32)
at com.intellij.openapi.application.impl.ApplicationImpl$2.call(ApplicationImpl.java:337)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1... (show balloon)

With this patch applied, I now get style complaints that make sense.

[bharathv]

Actually I forgot to mention this, mind putting a comment in a pom.xml next to the checkstyle version that one should also update this file if they are bumping up the checkstyle version? (if there is no automated way to keep them in sync).

[ndimiduk]

There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?

I'm afraid not, and no plans to add it at present. There's no abstraction that IDEA provides for this, so we'd need to implement code for each build system - Maven at least is just XML, but Gradle is an entirely different kettle of fish. I won't even think about SBT ... 😄

Even "just xml" is a bit of a warren. Thanks for checking in, @jshiell !

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	5m 58s	master passed
+1 💚	compile	3m 19s	master passed
+1 💚	checkstyle	2m 37s	master passed
+1 💚	shadedjars	5m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 32s	the patch passed
+1 💚	compile	3m 24s	the patch passed
+1 💚	javac	3m 24s	the patch passed
+1 💚	checkstyle	2m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	shadedjars	5m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 33s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	2m 53s	the patch passed
		_ Other Tests _
-1 ❌	unit	211m 53s	root in the patch failed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		277m 7s

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/artifact/out/Dockerfile
GITHUB PR	#1064
Optional Tests	dupname asflicense checkstyle xml javac javadoc unit shadedjars hadoopcheck compile
uname	Linux 6d51f4c309aa 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1064/out/precommit/personality/provided.sh
git revision	master / 753cc99
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/artifact/out/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/testReport/
Max. process+thread count	5136 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.