HBASE-23780 Edit of test classifications #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
saintstack
force-pushed
the
HBASE-23780
branch
from
b423232
to
9d88f13
Compare
|
💔 -1 overall
This message was automatically generated. |
saintstack
force-pushed
the
HBASE-23780
branch
from
9d88f13
to
0a440e6
Compare
|
💔 -1 overall
This message was automatically generated. |
These classifications come of running at various fork counts.. A test may complete quick if low fork count but if it is accessing disk, it will run much slower if fork count is high. This edit accommodates some of this phenomenon.
saintstack
force-pushed
the
HBASE-23780
branch
from
0a440e6
to
3025458
Compare
|
Test failures were because of fixes made for checkstyle complaints taking parameter private when should be public. This last push should be in. Would like to get it in. It moves around classfications based off study of tests run w/ current configs and with the upped throughputs that come of higher fork counts (more parallelism). Apart from changes in categories, only other changes are checkstyle complaints. |
bharathv
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
It moves around classfications based off study of tests run w/ current configs and with the upped throughputs that come of higher fork counts (more parallelism).
Thanks for putting this together. Curious if you did some automation around this (analyzing the test results) to get this data. If so that can probably be checked in too somewhere and we can have a bot that can point the mismatched categories based on test runtime or some other simple rules.
Reason I'm asking this is because it has to be repeated periodically, so wondering if there can be automation around it.
|
bq. Curious if you did some automation around this (analyzing the test results) to get this data. If so that can probably be checked in too somewhere and we can have a bot that can point the mismatched categories based on test runtime or some other simple rules. None on my part. A bunch of heuristics. Hard to do hard categorization. E.g. small test if < 15 seconds AND does not spin up a cluster of any type. Then for tests that do i/o, their elapsed time can vary wildly dependent on context. Whats here came of study over last few days. Yes, needs to be checked periodically. Something to work on. Thanks for the +1 @bharathv . Let me make sure the qa build comes in clean before merging. |
|
I see, thanks for the explanation. |
|
💔 -1 overall
This message was automatically generated. |
|
Rerun build. Tests pass locally. |
|
💔 -1 overall
This message was automatically generated. |
|
A different two failed. Retry. |
|
💔 -1 overall
This message was automatically generated. |
|
Merged. This patch doesn't touch failing test and can't repro locally. Will address in another issue if it persists. Thanks for the reviews all. |
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2020
These classifications come of running at various fork counts.. A test may complete quick if low fork count but if it is accessing disk, it will run much slower if fork count is high. This edit accommodates some of this phenomenon. Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
These classifications come of running at various fork counts.. A test may complete quick if low fork count but if it is accessing disk, it will run much slower if fork count is high. This edit accommodates some of this phenomenon. Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
These classifications come of running at various fork counts.. A test may complete quick if low fork count but if it is accessing disk, it will run much slower if fork count is high. This edit accommodates some of this phenomenon. Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
These classifications come of running at various fork counts.. A test may complete quick if low fork count but if it is accessing disk, it will run much slower if fork count is high. This edit accommodates some of this phenomenon. Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classifications come of running at various fork counts.. A test
may complete quick if low fork count but if it is accessing disk, it
will run much slower if fork count is high. This edit accommodates
some of this phenomenon.