Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support #1191

Merged

Conversation

ndimiduk
Copy link
Member

Two commits which I will squash after review

  1. copy-paste the existing script from the Jenkins job configuration
  2. address the shellcheck complaints

Step 3 will be to clean it up to match more closely the GitHub version. Would be great if they could be merged into one script, or at least two scripts with a common library of functions for building the Yetus invocation params list.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 37s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
2m 19s
Subsystem Report/Notes
Docker Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1191/1/artifact/out/Dockerfile
GITHUB PR #1191
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 67bec13fc7e9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1191/out/precommit/personality/provided.sh
git revision master / fe0d49b
Max. process+thread count 50 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1191/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit a5916c8 into apache:master Feb 24, 2020
@ndimiduk ndimiduk deleted the 23874-jira-precommit-yetus-invocation-script branch February 24, 2020 17:18
asfgit pushed a commit that referenced this pull request Feb 24, 2020
…in Jenkins config to dev-support (#1191) (ADDENDUM)

Addendum -- set new script executable
asfgit pushed a commit that referenced this pull request Feb 27, 2020
…in Jenkins config to dev-support (#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
asfgit pushed a commit that referenced this pull request Feb 27, 2020
…in Jenkins config to dev-support (#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
asfgit pushed a commit that referenced this pull request Feb 27, 2020
…in Jenkins config to dev-support (#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
asfgit pushed a commit that referenced this pull request Feb 27, 2020
…in Jenkins config to dev-support (#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
asfgit pushed a commit that referenced this pull request Feb 27, 2020
…in Jenkins config to dev-support (#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
asfgit pushed a commit that referenced this pull request Feb 27, 2020
…in Jenkins config to dev-support (#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…in Jenkins config to dev-support (apache#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…in Jenkins config to dev-support (apache#1191) (ADDENDUM)

Addendum -- set new script executable
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…in Jenkins config to dev-support (apache#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…in Jenkins config to dev-support (apache#1191) (ADDENDUM)

Addendum -- set new script executable
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…in Jenkins config to dev-support (apache#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit e8078b3)

Change-Id: I0cf551e32e41b86506103231f7cc18680613b4b5
udaynpusa pushed a commit to mapr/hbase that referenced this pull request Jan 30, 2024
…in Jenkins config to dev-support (apache#1191)

Signed-off-by: Sean Busbey <busbey@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants