Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23945 Dockerfiles showing hadolint check failures #1244

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Mar 6, 2020

With this patch, find . -iname '*Dockerfile*' -exec hadolint {} + reports nothing. Let's see what buildbot says.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 40s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
_ Other Tests _
2m 16s
Subsystem Report/Notes
Docker Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1244
Optional Tests
uname Linux 6439d2d9d91c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / df62dde
Max. process+thread count 52 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 15s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
_ Other Tests _
2m 47s
Subsystem Report/Notes
Docker Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1244
Optional Tests
uname Linux 4491fe159c62 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / df62dde
Max. process+thread count 51 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for patch
+1 💚 hadolint 0m 4s The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
2m 55s
Subsystem Report/Notes
Docker Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1244
Optional Tests dupname asflicense hadolint shellcheck shelldocs
uname Linux 9e09b4a6d17a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / df62dde
Max. process+thread count 45 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. LGTM. Try it.

Signed-off-by: stack <stack@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants