HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl. #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Mar 23, 2020
| @@ -747,9 +771,9 @@ private void resubmit(ServerName oldServer, List<Action> toReplay, | |||
| // It should be possible to have some heuristics to take the right decision. Short term, | |||
| // we go for one. | |||
| boolean retryImmediately = throwable instanceof RetryImmediatelyException; | |||
| int nextAttemptNumber = retryImmediately ? numAttempt : numAttempt + 1; | |||
| int nextAttemptNumber = numAttempt + 1; | |||
There was a problem hiding this comment.
How does this change our behavior @markrmiller
There was a problem hiding this comment.
I read the JIRA. That helped. I think you need a comment here on why the arbitrary '3'.... even it is just referring back to the issue. Thanks.
|
Any feedback on above @markrmiller ? |
|
The hope is that we retry the loop very fast a few times and then start putting a small delay between retries so you don't make enough recursive calls to eat all your stack space in just a short time if the call keeps failing. I'm open to input on what number to use, I picked one out of thin air, let's try fast a couple times and then slow down. |
|
Closing abandoned PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on branch-2, I ran into an issue where a retryable error kept occurring and code in AsyncRequestFutureImpl would reduce the backoff wait to 0 and extremely rapidly eat up a of thread stack space with recursive retry calls. This little patch stops the backoff wait kill after 3 retries. Chosen kind of arbitrarily, perhaps 5 is the right number, but I find large retry counts tend to hide things and that has made me default to fairly conservative in all my arbitrary number picking.