HBASE-23963 Split TestFromClientSide; it takes too long to complete t… #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Mar 11, 2020
| static int SLAVES = 1; | ||
|
|
||
| // To keep the child classes happy. | ||
| FromClientSideBase() {} |
There was a problem hiding this comment.
Better have these field and methods as protected? No a big deal though.
| /** | ||
| * Test all client operations with a coprocessor that just implements the default flush/compact/scan | ||
| * policy. | ||
| */ |
There was a problem hiding this comment.
Its doing the right thing w/o (there was no @RunWith before I showed up).
There was a problem hiding this comment.
Checked the code for RunWith
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
@Inherited
public @interface RunWith {
/**
* @return a Runner class (must have a constructor that takes a single Class to run)
*/
Class<? extends Runner> value();
}
It has an @Inherited annotation so it should be fine.
|
🎊 +1 overall
This message was automatically generated. |
|
Why a failed UT is also a -0? Because of this is a JDK11 run? Or? @ndimiduk |
|
And @saintstack sir, mind providing patch for master too? |
|
💔 -1 overall
This message was automatically generated. |
|
The run failed w/ OOME. Let me add in the protected annotations. Thanks for review @Apache9 |
…iming out Split TestGetFromClientSide. Means have to also split the superclass TestFromClientSideWithCoprocessor.
saintstack
force-pushed
the
2.HBASE-23963
branch
from
f42b839
to
472c290
Compare
|
I just pushed the last patch which adds in protected qualifiiers on base class to branch-2 after testing locally. I'm watching tests upstream so if issue will deal w/ it. Will forward-port to master now. Thanks for review @Apache9 |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Yes right now we have known failures with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iming out
Split TestGetFromClientSide. Means have to also split the superclass
TestFromClientSideWithCoprocessor.