HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust #1302

qiaoandxiang · 2020-03-18T00:28:14Z

Do not overwrite the hbase-site.xml which is being used by other tests.

ndimiduk · 2020-03-18T00:35:29Z

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionTool.java

-    config.set("fs.defaultFS", defaultFS);
-    String configPath = this.getClass().getClassLoader()
-      .getResource("hbase-site.xml").getFile();
-    config.writeXml(new FileOutputStream(new File(configPath)));


@wchevreuil can you comment as to why this test needed to write out it's hbase-site.xml? Presumably it was done for a reason and it's not enough to simply not write it out.

Apache-HBase · 2020-03-18T00:59:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 46s	master passed
+1 💚	compile	0m 33s	master passed
-1 ❌	shadedjars	0m 10s	branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 22s	hbase-mapreduce in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 28s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
-1 ❌	shadedjars	0m 9s	patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	hbase-mapreduce in the patch failed.
		_ Other Tests _
+1 💚	unit	7m 28s	hbase-mapreduce in the patch passed.
		24m 29s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1302
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1765da2b18e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
Default Java	2020-01-14
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/testReport/
Max. process+thread count	4325 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-18T01:08:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 45s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	5m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 59s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	shadedjars	6m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 29s	hbase-mapreduce in the patch passed.
		33m 0s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1302
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 87cc12047997 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/testReport/
Max. process+thread count	4108 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-18T01:13:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 54s	master passed
+1 💚	checkstyle	0m 20s	master passed
+1 💚	spotbugs	0m 48s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 15s	the patch passed
+1 💚	checkstyle	0m 19s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 15s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	spotbugs	1m 4s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		38m 24s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1302
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux b5310c596d39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…che#1302) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…che#1302) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 3263c20) Change-Id: I6e94b43cb8c528c6cba7217befed34efe06e1724

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust

4dfe7dc

ndimiduk requested a review from wchevreuil March 18, 2020 00:34

ndimiduk reviewed Mar 18, 2020

View reviewed changes

saintstack merged commit 52a04e6 into apache:master Mar 19, 2020

asfgit pushed a commit that referenced this pull request Mar 19, 2020

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust (#1302)

5e764f5

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

asfgit pushed a commit that referenced this pull request Mar 19, 2020

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust (#1302)

3c4cbf1

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

asfgit pushed a commit that referenced this pull request Mar 19, 2020

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust (#1302)

3263c20

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust (apa…

ab4ee6a

…che#1302) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust (apa…

a072385

…che#1302) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust #1302

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust #1302

qiaoandxiang commented Mar 18, 2020

ndimiduk Mar 18, 2020

Apache-HBase commented Mar 18, 2020

Apache-HBase commented Mar 18, 2020

Apache-HBase commented Mar 18, 2020

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust #1302

HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust #1302

Conversation

qiaoandxiang commented Mar 18, 2020

ndimiduk Mar 18, 2020

Choose a reason for hiding this comment

Apache-HBase commented Mar 18, 2020

Apache-HBase commented Mar 18, 2020

Apache-HBase commented Mar 18, 2020