Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2 #1331

Merged

Conversation

ndimiduk
Copy link
Member

Does what it says on the tin. Bound to initialize phase so that it
runs early in lifecycle. Uses <inherited>false</inherited> so that
the plugin will run only for the base pom's reactor stage and not for
any children.

Signed-off-by: Viraj Jasani vjasani@apache.org
Signed-off-by: Jan Hentschel jan.hentschel@ultratendency.com

Does what it says on the tin. Bound to `initialize` phase so that it
runs early in lifecycle. Uses `<inherited>false</inherited>` so that
the plugin will run only for the base pom's reactor stage and not for
any children.

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
_ Patch Compile Tests _
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 12m 14s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
21m 4s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1331
Optional Tests dupname asflicense hadoopcheck xml
uname Linux 69115da13d8d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1147c23
Max. process+thread count 63 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 41s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 7m 21s branch-2 passed
+1 💚 compile 4m 24s branch-2 passed
-1 ❌ shadedjars 0m 10s branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 21s root in branch-2 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 7m 8s the patch passed
+1 💚 compile 4m 16s the patch passed
+1 💚 javac 4m 16s the patch passed
-1 ❌ shadedjars 0m 9s patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s root in the patch failed.
_ Other Tests _
-0 ⚠️ unit 170m 27s root in the patch failed.
198m 29s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1331
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8ba2b37fe215 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1147c23
Default Java 2020-01-14
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/testReport/
Max. process+thread count 4221 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 41s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 6m 21s branch-2 passed
+1 💚 compile 3m 31s branch-2 passed
+1 💚 shadedjars 5m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 1s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 46s the patch passed
+1 💚 compile 3m 54s the patch passed
+1 💚 javac 3m 54s the patch passed
+1 💚 shadedjars 5m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 19s the patch passed
_ Other Tests _
+1 💚 unit 201m 55s root in the patch passed.
244m 12s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1331
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3bc7cfc6daf6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1147c23
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/testReport/
Max. process+thread count 5056 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 7d89a98 into apache:branch-2 Mar 24, 2020
@ndimiduk ndimiduk deleted the 23980-enforcer-display-info-branch-2 branch March 24, 2020 16:19
@ndimiduk
Copy link
Member Author

@HorizonNet Thanks Jan. I wasn't looking for further reviews on back ports, just wanted to see what PreCommit had to say before pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants