HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile #1342

ndimiduk · 2020-03-25T00:46:59Z

https://stackoverflow.com/a/28870635 claims nio is more reliable than the old File API, so try that instead.

ndimiduk · 2020-03-25T00:47:37Z

Mind giving it a spin if you can repro the original issue, @saintstack , @jojochuang ?

Apache-HBase · 2020-03-25T01:35:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 58s	master passed
+1 💚	checkstyle	1m 11s	master passed
+1 💚	spotbugs	2m 2s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 20s	the patch passed
+1 💚	checkstyle	1m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 58s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 11s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		40m 7s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1342
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 7cf3a017fb4d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aa966e3`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Reidddddd

I'm fine with the new API in master branch. +1

Apache-HBase · 2020-03-25T02:36:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 42s	master passed
+1 💚	compile	1m 7s	master passed
+1 💚	shadedjars	5m 56s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 19s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	5m 50s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	68m 14s	hbase-server in the patch failed.
		100m 42s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1342
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 84b83956fa3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aa966e3`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/testReport/
Max. process+thread count	6463 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-25T02:38:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 43s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	shadedjars	5m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 49s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	5m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	71m 52s	hbase-server in the patch passed.
		103m 33s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1342
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2391079dc327 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aa966e3`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/testReport/
Max. process+thread count	5897 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1342/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-03-25T02:52:09Z

Issue doesn't fail for me so hard to see if this makes a diff.

ndimiduk · 2020-03-25T17:24:34Z

Yeah, was hoping @jojochuang could give it a spin.

ndimiduk · 2020-03-27T19:03:22Z

Well @saintstack @Reidddddd @jojochuang what do you think? This doesn't fix the test for me, but makes it flake a little less frequently. You lads want to run this one in a loop and see if it improves things for you at all? Should we just commit it? Abandon it? Keep looking for the true cause?

saintstack · 2020-05-04T21:55:34Z

What you want to do here @ndimiduk ? Fails for you still? I haven't seen it show up in a while sir.

ndimiduk · 2020-05-04T22:53:58Z

I was hoping master @jojochuang could let me know if this helps his case, given that it was failing reliably for him but not for me.

jojochuang · 2020-05-06T04:52:51Z

+1 although I don't understand why, but the test no longer fails.

#1342) Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile

8efec02

Reidddddd approved these changes Mar 25, 2020

View reviewed changes

saintstack approved these changes Mar 25, 2020

View reviewed changes

jojochuang approved these changes May 6, 2020

View reviewed changes

saintstack merged commit 07077a3 into apache:master May 6, 2020

saintstack pushed a commit that referenced this pull request May 6, 2020

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile (

e6b8ca9

#1342) Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>

saintstack pushed a commit that referenced this pull request May 6, 2020

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile (

d28b56f

#1342) Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile #1342

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile #1342

ndimiduk commented Mar 25, 2020

ndimiduk commented Mar 25, 2020

Apache-HBase commented Mar 25, 2020

Reidddddd left a comment

Apache-HBase commented Mar 25, 2020

Apache-HBase commented Mar 25, 2020

saintstack commented Mar 25, 2020

ndimiduk commented Mar 25, 2020

ndimiduk commented Mar 27, 2020

saintstack commented May 4, 2020

ndimiduk commented May 4, 2020

jojochuang commented May 6, 2020

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile #1342

HBASE-23976 Use nio for file manipulation in TestVerifyBucketCacheFile #1342

Conversation

ndimiduk commented Mar 25, 2020

ndimiduk commented Mar 25, 2020

Apache-HBase commented Mar 25, 2020

Reidddddd left a comment

Choose a reason for hiding this comment

Apache-HBase commented Mar 25, 2020

Apache-HBase commented Mar 25, 2020

saintstack commented Mar 25, 2020

ndimiduk commented Mar 25, 2020

ndimiduk commented Mar 27, 2020

saintstack commented May 4, 2020

ndimiduk commented May 4, 2020

jojochuang commented May 6, 2020