HBASE-8868. add metric to report client shortcircuit reads. (#1334)

[jojochuang]

Signed-off-by: stack stack@apache.net
(cherry picked from commit 4ec1909)

Conflicts:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java

[jojochuang]

The patch applies quite cleanly. Only one line of conflict in the import.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ branch-2.2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 7s	branch-2.2 passed
+1 💚	compile	2m 53s	branch-2.2 passed
+1 💚	checkstyle	3m 58s	branch-2.2 passed
+0 🆗	refguide	16m 26s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	4m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 51s	branch-2.2 passed
+0 🆗	spotbugs	2m 36s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	15m 45s	branch-2.2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 41s	the patch passed
+1 💚	compile	2m 50s	the patch passed
+1 💚	javac	2m 50s	the patch passed
-1 ❌	checkstyle	1m 26s	hbase-server: The patch generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-1 ❌	checkstyle	2m 24s	root: The patch generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	5m 16s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	21m 0s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚	javadoc	3m 57s	the patch passed
+1 💚	findbugs	16m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	227m 0s	root in the patch passed.
+1 💚	asflicense	2m 37s	The patch does not generate ASF License warnings.
		352m 50s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/artifact/out/Dockerfile
GITHUB PR	#1393
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide
uname	Linux ca868e0fb6a4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1393/out/precommit/personality/provided.sh
git revision	branch-2.2 / 88c0883
Default Java	1.8.0_181
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/artifact/out/branch-site/book.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/artifact/out/diff-checkstyle-hbase-server.txt
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/artifact/out/diff-checkstyle-root.txt
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/artifact/out/patch-site/book.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/testReport/
Max. process+thread count	5597 (vs. ulimit of 10000)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1393/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[busbey]

looks like the checkstyle complaints were there in the original patch for master. not worth fixing just on the backport.