HBASE-8868. add metric to report client shortcircuit reads. #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
The test TestVerifyBucketCacheFile#testRetrieveFromFile fails consistently. However, it doesn't look like it was introduced by this patch. HBASE-23976 Nick reported the same issue. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Believe the test failure is due to HBASE-23829. |
asfgit
pushed a commit
that referenced
this pull request
Mar 24, 2020
Signed-off-by: stack <stack@apache.net>
asfgit
pushed a commit
that referenced
this pull request
Mar 24, 2020
Signed-off-by: stack <stack@apache.net>
|
Thanks Stack! |
jojochuang
added a commit
to jojochuang/hbase
that referenced
this pull request
Mar 31, 2020
) Signed-off-by: stack <stack@apache.net> (cherry picked from commit 4ec1909) Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
jojochuang
added a commit
to jojochuang/hbase
that referenced
this pull request
Apr 3, 2020
Signed-off-by: stack <stack@apache.net> (cherry picked from commit 4ec1909) Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
asfgit
pushed a commit
that referenced
this pull request
Apr 15, 2020
branch-1 backport of #1334 Signed-off-by: stack <stack@apache.net> Signed-off-by: Sean Busbey <busbey@apache.org> Co-authored-by: Andrew Purtell <apurtell@apache.org>
Reidddddd
pushed a commit
to Reidddddd/hbase
that referenced
this pull request
Apr 22, 2020
branch-1 backport of apache#1334 Signed-off-by: stack <stack@apache.net> Signed-off-by: Sean Busbey <busbey@apache.org> Co-authored-by: Andrew Purtell <apurtell@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
branch-2.2 backport of apache#1334 Signed-off-by: stack <stack@apache.net> (cherry picked from commit 4ec1909) Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit 8a15e0b) Change-Id: I259f77f1fbec1725873bfac9dab944267851648d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose file system level read metrics for RegionServer.
If the HBase RS runs on top of HDFS, calculate the aggregation of
ReadStatistics of each HdfsFileInputStream. These metrics include:
(1) total number of bytes read from HDFS.
(2) total number of bytes read from local DataNode.
(3) total number of bytes read locally through short-circuit read.
(4) total number of bytes read locally through zero-copy read.
Because HDFS ReadStatistics is calculated per input stream, it is not
feasible to update the aggregated number in real time. Instead, the
metrics are updated when an input stream is closed.