New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24084 Fix missing jdk8 dependencies in hbase-assembly/hadoop-two-compat #1413
HBASE-24084 Fix missing jdk8 dependencies in hbase-assembly/hadoop-two-compat #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if it works.
🎊 +1 overall
This message was automatically generated. |
For reviewer reference (@jatsakthi in particular), the transitive dependency hull of
And of
|
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Yeah seems to work for me locally. All this JDK11 complication can be purged from the hadoop-two profiles since that combination is known to not work at runtime. |
…o-compat After HBASE-23986, running on JDK8/Hadoop2 from the binary tarball results in ``` Exception in thread "main" java.lang.NoClassDefFoundError: com/ctc/wstx/io/InputBootstrapper at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3062) Caused by: java.lang.ClassNotFoundException: com.ctc.wstx.io.InputBootstrapper at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 2 more ``` The missing class is from `com.fasterxml.woodstox:woodstox-core`. This and `org.codehaus.woodstox:stax2-api` are explicit dependencies of `org.apache.hadoop:hadoop-common:jar:2.10.0`. Thus, include them in the default jars provided under `lib`. Signed-off-by: stack <stack@apache.org>
a0ab2e1
to
704a3a5
Compare
sort lines and cleanup whitespace in hbase-assembly/hadoop-two-compat.xml
Simply cleanup the whitespace and readability of these include, exclude lists before making any subsequent changes. To be squished into the subsequent commit on merge.
HBASE-24084 Fix missing jdk8 dependencies in hbase-assembly/hadoop-two-compat
After HBASE-23986, running on JDK8/Hadoop2 from the binary tarball
results in
The missing class is from
com.fasterxml.woodstox:woodstox-core
. Thisand
org.codehaus.woodstox:stax2-api
are explicit dependencies oforg.apache.hadoop:hadoop-common:jar:2.10.0
. Thus, include them inthe default jars provided under
lib
.