Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Back-port branch-1]: HBASE-24112 [RSGroup] Support renaming rsgroup #1467

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

Reidddddd
Copy link
Contributor

This pr is for branch-1.

@Reidddddd Reidddddd changed the title HBASE-24112 [RSGroup] Support renaming rsgroup HBASE-24112 [RSGroup] Support renaming rsgroup for branch-1 Apr 9, 2020
@Reidddddd Reidddddd requested a review from apurtell April 9, 2020 08:41
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 1m 23s Maven dependency ordering for branch
+1 💚 mvninstall 7m 29s branch-1 passed
+1 💚 compile 1m 28s branch-1 passed with JDK v1.8.0_242
+1 💚 compile 1m 39s branch-1 passed with JDK v1.7.0_252
+1 💚 checkstyle 4m 40s branch-1 passed
+1 💚 shadedjars 3m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 4s branch-1 passed with JDK v1.8.0_242
+1 💚 javadoc 1m 15s branch-1 passed with JDK v1.7.0_252
+0 🆗 spotbugs 2m 50s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 6m 1s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 1m 58s the patch passed
+1 💚 compile 1m 30s the patch passed with JDK v1.8.0_242
+1 💚 cc 1m 30s the patch passed
+1 💚 javac 1m 30s the patch passed
+1 💚 compile 1m 41s the patch passed with JDK v1.7.0_252
+1 💚 cc 1m 41s the patch passed
+1 💚 javac 1m 41s the patch passed
-1 ❌ checkstyle 0m 19s hbase-rsgroup: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 3m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 6m 1s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 hbaseprotoc 2m 10s the patch passed
+1 💚 javadoc 1m 7s the patch passed with JDK v1.8.0_242
+1 💚 javadoc 1m 28s the patch passed with JDK v1.7.0_252
+1 💚 findbugs 7m 38s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-protocol in the patch passed.
+1 💚 unit 131m 41s hbase-server in the patch passed.
+1 💚 unit 13m 1s hbase-rsgroup in the patch passed.
+1 💚 asflicense 1m 16s The patch does not generate ASF License warnings.
212m 37s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/1/artifact/out/Dockerfile
GITHUB PR #1467
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 27b1cda845b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1467/out/precommit/personality/provided.sh
git revision branch-1 / 4b94f2e
Default Java 1.7.0_252
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/1/artifact/out/diff-checkstyle-hbase-rsgroup.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/1/testReport/
Max. process+thread count 4383 (vs. ulimit of 10000)
modules C: hbase-protocol hbase-server hbase-rsgroup U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd changed the title HBASE-24112 [RSGroup] Support renaming rsgroup for branch-1 HBASE-24112 [branch-1] [RSGroup] Support renaming rsgroup Apr 11, 2020
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 8m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 1m 25s Maven dependency ordering for branch
+1 💚 mvninstall 7m 43s branch-1 passed
+1 💚 compile 1m 29s branch-1 passed with JDK v1.8.0_242
+1 💚 compile 1m 39s branch-1 passed with JDK v1.7.0_252
+1 💚 checkstyle 4m 43s branch-1 passed
+1 💚 shadedjars 3m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 3s branch-1 passed with JDK v1.8.0_242
+1 💚 javadoc 1m 14s branch-1 passed with JDK v1.7.0_252
+0 🆗 spotbugs 2m 45s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 2m 42s hbase-server in branch-1 has 1 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 2m 7s the patch passed
+1 💚 compile 1m 26s the patch passed with JDK v1.8.0_242
+1 💚 cc 1m 26s the patch passed
+1 💚 javac 1m 26s the patch passed
+1 💚 compile 1m 34s the patch passed with JDK v1.7.0_252
+1 💚 cc 1m 34s the patch passed
+1 💚 javac 1m 34s the patch passed
+1 💚 checkstyle 4m 18s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 49s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 50s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 hbaseprotoc 1m 46s the patch passed
+1 💚 javadoc 0m 57s the patch passed with JDK v1.8.0_242
+1 💚 javadoc 1m 14s the patch passed with JDK v1.7.0_252
+1 💚 findbugs 6m 10s the patch passed
_ Other Tests _
+1 💚 unit 0m 28s hbase-protocol in the patch passed.
+1 💚 unit 128m 43s hbase-server in the patch passed.
+1 💚 unit 12m 19s hbase-rsgroup in the patch passed.
+1 💚 asflicense 1m 25s The patch does not generate ASF License warnings.
210m 46s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/2/artifact/out/Dockerfile
GITHUB PR #1467
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 3b5f6cb925af 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1467/out/precommit/personality/provided.sh
git revision branch-1 / 7b12709
Default Java 1.7.0_252
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/2/artifact/out/branch-findbugs-hbase-server-warnings.html
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/2/testReport/
Max. process+thread count 4181 (vs. ulimit of 10000)
modules C: hbase-protocol hbase-server hbase-rsgroup U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1467/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd changed the title HBASE-24112 [branch-1] [RSGroup] Support renaming rsgroup [Back-port] branch-1: HBASE-24112 [RSGroup] Support renaming rsgroup Apr 13, 2020
@Reidddddd Reidddddd changed the title [Back-port] branch-1: HBASE-24112 [RSGroup] Support renaming rsgroup [Back-port branch-1]: HBASE-24112 [RSGroup] Support renaming rsgroup Apr 15, 2020
@Reidddddd
Copy link
Contributor Author

The findbug warning is not related to this branch, let's commit first.

@Reidddddd Reidddddd merged commit 0d86835 into apache:branch-1 Apr 15, 2020
@Reidddddd Reidddddd deleted the HBASE-24112 branch April 15, 2020 11:20
Reidddddd added a commit to Reidddddd/hbase that referenced this pull request Apr 22, 2020
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants