Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek… #1522

Merged
merged 1 commit into from
Apr 16, 2020
Merged

HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek… #1522

merged 1 commit into from
Apr 16, 2020

Conversation

virajjasani
Copy link
Contributor

…er to named inner classes

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 7s master passed
+1 💚 compile 0m 25s master passed
+1 💚 shadedjars 5m 29s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-common in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 shadedjars 5m 22s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-common in the patch failed.
_ Other Tests _
+1 💚 unit 1m 29s hbase-common in the patch passed.
23m 31s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1522
Optional Tests javac javadoc unit shadedjars compile
uname Linux b70e066107f9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 38954ed
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/testReport/
Max. process+thread count 271 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 40s master passed
+1 💚 compile 0m 25s master passed
+1 💚 shadedjars 5m 59s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 33s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 15s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 shadedjars 5m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s the patch passed
_ Other Tests _
+1 💚 unit 1m 44s hbase-common in the patch passed.
26m 43s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1522
Optional Tests javac javadoc unit shadedjars compile
uname Linux 034b856621c3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 38954ed
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/testReport/
Max. process+thread count 226 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 27s master passed
+1 💚 checkstyle 0m 26s master passed
+1 💚 spotbugs 0m 50s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 55s the patch passed
-0 ⚠️ checkstyle 0m 25s hbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 6s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 0m 51s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
30m 51s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1522
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 203a8a5e4be3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 38954ed
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

binlijin
binlijin approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@binlijin binlijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani merged commit 24e15c0 into apache:master Apr 16, 2020
@virajjasani virajjasani deleted the HBASE-24194-master branch April 16, 2020 13:46
virajjasani added a commit that referenced this pull request Apr 16, 2020
@virajjasani
HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek…
ca1f7a9 
…er to named inner classes (#1522)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
virajjasani added a commit that referenced this pull request Apr 16, 2020
@virajjasani
HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek…
0990d35 
…er to named inner classes (#1522)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
virajjasani added a commit that referenced this pull request Apr 16, 2020
@virajjasani
HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek…
d4b64c2 
…er to named inner classes (#1522)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@virajjasani @ddupg
HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek…
344b0f2 
…er to named inner classes (apache#1522)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@virajjasani
HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek…
a5c1ba3 
…er to named inner classes (apache#1522)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binlijin binlijin binlijin approved these changes

@petersomogyi petersomogyi petersomogyi approved these changes

@saintstack saintstack Awaiting requested review from saintstack

@HorizonNet HorizonNet Awaiting requested review from HorizonNet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@virajjasani @Apache-HBase @binlijin @petersomogyi