HBASE-24195 : Admin.getRegionServers() should return live servers exc… #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luding decom RS optionally
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
liuml07
reviewed
Apr 16, 2020
| waitForServerDecom(serverToDecommission, true); | ||
|
|
||
| Assert.assertEquals(2, ADMIN.getRegionServers(true).size()); | ||
|
|
There was a problem hiding this comment.
Add Assert.assertEquals(3, ADMIN.getRegionServers(false).size()); for paranoid reviewers (cough cough me).
There was a problem hiding this comment.
Sure, definitely
| ADMIN.recommissionRegionServer(serverToDecommission, Collections.emptyList()); | ||
|
|
||
| Assert.assertEquals(3, ADMIN.getRegionServers(true).size()); | ||
| waitForServerDecom(serverToDecommission, false); |
There was a problem hiding this comment.
Why wait for decommission this server in the end?
There was a problem hiding this comment.
I was thinking the assertion Assert.assertEquals(3, ADMIN.getRegionServers(true).size()); should have made sure all RS are fine now. I understand in case that is not enough, you explicitly make sure the mini cluster is ready for other test cases. OK, good.
There was a problem hiding this comment.
Why wait for decommission this server in the end?
Actually, we are waiting for server to be recommissioned (maybe method name not correct, last arg determines). Let me change the order.
| return allServers; | ||
| } | ||
| List<ServerName> decommissionedRegionServers = listDecommissionedRegionServers(); | ||
| if (CollectionUtils.isNotEmpty(decommissionedRegionServers)) { |
There was a problem hiding this comment.
if (CollectionUtils.isNotEmpty(decommissionedRegionServers)) {
allServers = new ArrayList<>(allServers);
allServers.removeIf(decommissionedRegionServers::contains);
return Collections.unmodifiableList(allServers);
}
return allServers;
to
return allServers.stream()
.filter(s -> !decommissionedRegionServers.contains(s))
.collect(ImmutableList.toImmutableList());
I think this will save one time full copy (previous code copy twice, and this copies just once). Need to confirm.
There was a problem hiding this comment.
The reason behind copy (new ArrayList<>(allServers)) was making allServers unmodifiable list. So ImmutableList.toImmutableList() seems to be solving our problem.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
reviewed
Apr 16, 2020
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
Show resolved
Hide resolved
HorizonNet
approved these changes
Apr 16, 2020
virajjasani
added a commit
that referenced
this pull request
Apr 16, 2020
#1523) Signed-off-by: Mingliang Liu <liuml07@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
virajjasani
added a commit
that referenced
this pull request
Apr 16, 2020
#1523) Signed-off-by: Mingliang Liu <liuml07@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
ddupg
pushed a commit
to ddupg/hbase
that referenced
this pull request
Apr 20, 2020
apache#1523) Signed-off-by: Mingliang Liu <liuml07@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…luding decom RS optionally