HBASE-24211: Create table is slow in large cluster when AccessController is enabled. #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Apr 18, 2020
| @@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw, String znode) | |||
| if (nodes != null) { | |||
| List<NodeAndData> newNodes = new ArrayList<>(); | |||
| for (String node : nodes) { | |||
| if (Thread.interrupted()) { | |||
| // Partial data should not be processed. Cancel processing by sending empty list. | |||
| return new ArrayList<>(); | |||
There was a problem hiding this comment.
returning Collections.emptyList() would be better
| ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode); | ||
| refreshNodes(nodeList); | ||
| } catch (KeeperException ke) { | ||
| LOG.error("Error reading data from zookeeper for path " + path, ke); |
There was a problem hiding this comment.
Please user {} for LOG param path
There was a problem hiding this comment.
Or better create a string variable and use it for both LOG.error and abort message.
virajjasani
reviewed
Apr 18, 2020
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Apr 21, 2020
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
pankaj72981
approved these changes
Apr 23, 2020
|
@arshadmohammad Please let me know once you create PRs for branch-2 and branch-1. We can target to merge this to master, branch-2, 2.3 (to be covered by branch-2) and branch-1. |
|
This PR code applies to branch-2 branch-2.3. |
virajjasani
pushed a commit
that referenced
this pull request
Apr 25, 2020
…ler is enabled. (#1546) Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Pankaj <pankajkumar@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Apr 25, 2020
…ler is enabled. (#1546) Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Pankaj <pankajkumar@apache.org>
|
This PR changes were reverted back. Created new PR #1631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create table is slow in large cluster when AccessController is enabled.