HBASE-16002 Made constructors of DataType subclasses public #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Apr 17, 2019
| @@ -32,7 +32,7 @@ | |||
| public static final OrderedBlob ASCENDING = new OrderedBlob(Order.ASCENDING); | |||
| public static final OrderedBlob DESCENDING = new OrderedBlob(Order.DESCENDING); | |||
|
|
|||
| protected OrderedBlob(Order order) { | |||
| public OrderedBlob(Order order) { | |||
There was a problem hiding this comment.
I think this is intentional? User can use the above ASCENDING and DESCENDING directly?
There was a problem hiding this comment.
I would guess so. @ndimiduk probably can answer this question better.
There was a problem hiding this comment.
So that's precisely it. See my last comment on JIRA. The original design of this part of the API was to try to prevent callers from needless allocations. That couldn't be done uniformly, though, as some of these implementations require explicit construction parameters. I myself filed a ticket wondering why I had left some constructors private. I believe the uniformity of public constructors across all concrete types is more consistent that having static constants in most, but not all, places.
This is definitely a subjective area of the API design and I'd love to get other opinions :)
There was a problem hiding this comment.
To make it consistent, how about making the constructors public for consistency reasons and deprecate the static constants (and remove them in another release) to make it more consistent?
There was a problem hiding this comment.
If you think deprecating the static constants is appropriate, then I have no objection. There's always a balance between minimizing our supported surface area and downstream convenience. I've not followed things very closely as of late, but it seems we're on a pretty strong kick to deprecate/drop old interfaces.
There was a problem hiding this comment.
I think that we should discuss this on the dev list. @Apache9 Is your question answered? What do you think? Should we leave it as is or should we deprecate the static constants?
This was referenced Apr 17, 2019
|
🎊 +1 overall
This message was automatically generated. |
This was referenced Apr 26, 2019
|
IMO make all constructors public (and deprecate the static defines). Its consistent. If a problem w/ too many new objects, can review then. |
This was referenced Jun 7, 2019
|
🎊 +1 overall
This message was automatically generated. |
This was referenced Jun 11, 2019
|
Updated the PR to deprecate the static defines and the default constructors (for consistency). Because I was already on it, I added some test cases for the types. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
This was referenced Aug 20, 2021
This was referenced Aug 27, 2021
This was referenced Sep 4, 2021
HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table
#3666
Merged
This was referenced Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.