Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22280 Separate read/write handler for priority request(especial… #202

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

binlijin
Copy link
Contributor

…ly for meta).

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 162 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 1 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 269 master passed
+1 compile 55 master passed
+1 checkstyle 68 master passed
+1 shadedjars 265 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 210 master passed
+1 javadoc 35 master passed
_ Patch Compile Tests _
-1 mvninstall 167 root in the patch failed.
+1 compile 54 the patch passed
+1 javac 54 the patch passed
-1 checkstyle 68 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 214 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 119 The patch causes 11 errors with Hadoop v2.7.4.
-1 hadoopcheck 246 The patch causes 11 errors with Hadoop v3.0.0.
+1 findbugs 215 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
-1 unit 53 hbase-server in the patch failed.
+1 asflicense 14 The patch does not generate ASF License warnings.
2210
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a7a658b46f6e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / f9f6354
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-javac-2.7.4.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-javac-3.0.0.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Member

@carp84 carp84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new UT case to cover MetaRWQueueRpcExecutor

@carp84
Copy link
Member

carp84 commented May 14, 2019

Please also check the mvninstall, checkstyle and UT error reported by robot

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 30 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 349 master passed
+1 compile 85 master passed
+1 checkstyle 79 master passed
+1 shadedjars 345 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 418 master passed
+1 javadoc 52 master passed
_ Patch Compile Tests _
-1 mvninstall 267 root in the patch failed.
+1 compile 90 the patch passed
+1 javac 90 the patch passed
-1 checkstyle 85 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 315 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 184 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 368 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 570 The patch causes 11 errors with Hadoop v3.1.2.
+1 findbugs 345 the patch passed
+1 javadoc 55 the patch passed
_ Other Tests _
-1 unit 98 hbase-server in the patch failed.
+1 asflicense 19 The patch does not generate ASF License warnings.
3296
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4571e48797fb 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / ada772a
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/
Max. process+thread count 50 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

Any updates here @binlijin ? Thanks.

@binlijin
Copy link
Contributor Author

binlijin commented Jun 25, 2019

@saintstack i am sorry that i can not do the contribution now for some reason, someone else can take it over.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 230 master passed
+1 compile 50 master passed
+1 checkstyle 65 master passed
+1 shadedjars 261 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 204 master passed
+1 javadoc 30 master passed
_ Patch Compile Tests _
-1 mvninstall 155 root in the patch failed.
+1 compile 53 the patch passed
+1 javac 53 the patch passed
-1 checkstyle 67 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 207 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 115 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 229 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 349 The patch causes 11 errors with Hadoop v3.1.2.
+1 findbugs 207 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
-1 unit 55 hbase-server in the patch failed.
+1 asflicense 13 The patch does not generate ASF License warnings.
2068
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux abb2e4ccaa87 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 438bf32
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 232 master passed
+1 compile 53 master passed
+1 checkstyle 67 master passed
+1 shadedjars 268 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 206 master passed
+1 javadoc 34 master passed
_ Patch Compile Tests _
-1 mvninstall 157 root in the patch failed.
+1 compile 54 the patch passed
+1 javac 54 the patch passed
-1 checkstyle 67 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 1 The patch has no whitespace issues.
-1 shadedjars 211 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 116 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 235 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 357 The patch causes 11 errors with Hadoop v3.1.2.
+1 findbugs 215 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
-1 unit 54 hbase-server in the patch failed.
+1 asflicense 12 The patch does not generate ASF License warnings.
2115
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 99acbbc184e2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 74731c2
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 255 master passed
+1 compile 56 master passed
+1 checkstyle 70 master passed
+1 shadedjars 274 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 222 master passed
+1 javadoc 31 master passed
_ Patch Compile Tests _
-1 mvninstall 162 root in the patch failed.
+1 compile 53 the patch passed
+1 javac 53 the patch passed
-1 checkstyle 67 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 216 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 128 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 249 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 371 The patch causes 11 errors with Hadoop v3.1.2.
+1 findbugs 228 the patch passed
+1 javadoc 35 the patch passed
_ Other Tests _
-1 unit 53 hbase-server in the patch failed.
+1 asflicense 15 The patch does not generate ASF License warnings.
2201
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 68b1ac49ea09 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / cc38de1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/testReport/
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 80 root in master failed.
-1 compile 38 hbase-server in master failed.
+1 checkstyle 65 master passed
+1 shadedjars 250 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 225 master passed
+1 javadoc 32 master passed
_ Patch Compile Tests _
-1 mvninstall 13 root in the patch failed.
-1 compile 35 hbase-server in the patch failed.
-1 javac 35 hbase-server in the patch failed.
-1 checkstyle 63 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 201 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 10 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 19 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 29 The patch causes 10 errors with Hadoop v3.1.2.
+1 findbugs 222 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
-1 unit 33 hbase-server in the patch failed.
+1 asflicense 9 The patch does not generate ASF License warnings.
1464
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a540931346bc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 72e58a8
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/branch-compile-hbase-server.txt
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 188 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 250 root in master failed.
+1 compile 56 master passed
+1 checkstyle 62 master passed
+1 shadedjars 267 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 221 master passed
+1 javadoc 31 master passed
_ Patch Compile Tests _
-1 mvninstall 157 root in the patch failed.
+1 compile 50 the patch passed
+1 javac 50 the patch passed
-1 checkstyle 67 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 205 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 112 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 233 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 361 The patch causes 11 errors with Hadoop v3.1.2.
+1 findbugs 149 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
-1 unit 54 hbase-server in the patch failed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2226
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux cb3b4619b2b5 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 00075ea
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/branch-mvninstall-root.txt
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/testReport/
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 55 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 265 master passed
+1 compile 61 master passed
+1 checkstyle 73 master passed
+1 shadedjars 301 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 master passed
0 spotbugs 285 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 282 master passed
_ Patch Compile Tests _
-1 mvninstall 167 root in the patch failed.
+1 compile 53 the patch passed
+1 javac 53 the patch passed
-1 checkstyle 71 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 224 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 123 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 246 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 377 The patch causes 11 errors with Hadoop v3.1.2.
+1 javadoc 36 the patch passed
+1 findbugs 279 the patch passed
_ Other Tests _
-1 unit 57 hbase-server in the patch failed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2417
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a00bca78553a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revision master / c9293b0
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/testReport/
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 61 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 239 master passed
+1 compile 56 master passed
+1 checkstyle 74 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
-1 javadoc 18 hbase-server in master failed.
0 spotbugs 319 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 38 hbase-server in master failed.
_ Patch Compile Tests _
-1 mvninstall 166 root in the patch failed.
-1 compile 35 hbase-server in the patch failed.
-1 javac 35 hbase-server in the patch failed.
-1 checkstyle 70 hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 208 patch has 11 errors when building our shaded downstream artifacts.
-1 hadoopcheck 119 The patch causes 11 errors with Hadoop v2.8.5.
-1 hadoopcheck 240 The patch causes 11 errors with Hadoop v2.9.2.
-1 hadoopcheck 366 The patch causes 11 errors with Hadoop v3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 251 the patch passed
_ Other Tests _
-1 unit 56 hbase-server in the patch failed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2002
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c3d57cee89a4 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revision master / aa9679d
Default Java 1.8.0_181
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/branch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/testReport/
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@binlijin binlijin reopened this Oct 31, 2019
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 33s Docker mode activated.
_ Prechecks _
💚 dupname 0m 1s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚 mvninstall 5m 30s master passed
💚 compile 0m 56s master passed
💚 checkstyle 1m 17s master passed
💚 shadedjars 4m 36s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 37s master passed
💙 spotbugs 3m 55s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 3m 52s master passed
_ Patch Compile Tests _
💚 mvninstall 4m 54s the patch passed
💚 compile 0m 56s the patch passed
💚 javac 0m 56s the patch passed
💚 checkstyle 1m 19s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 37s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 15m 33s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 36s the patch passed
💚 findbugs 4m 7s the patch passed
_ Other Tests _
💔 unit 162m 49s hbase-server in the patch failed.
💚 asflicense 0m 34s The patch does not generate ASF License warnings.
219m 13s
Reason Tests
Failed junit tests hadoop.hbase.master.assignment.TestReportOnlineRegionsRace
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0e66ee070ec5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revision master / e1b4a2a
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/testReport/
Max. process+thread count 4924 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@carp84 carp84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the UT result we could see below error:

[ERROR] Failures:
[ERROR] TestReportOnlineRegionsRace.testRace:167 Waiting timed out after [10,000] msec
[ERROR] Errors:
[ERROR] TestReportOnlineRegionsRace.setUp:130 » TimeoutIO java.util.concurrent.Timeout...

I checked in local environment and reproduced the error, and there's no such issue if we revert the commit of this PR, so this is a regression must be fixed.

@binlijin
Copy link
Contributor Author

@carp84 fix the ut, the test need at least two write handler when use separate read/write handlers.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 5m 23s master passed
+1 💚 compile 0m 55s master passed
+1 💚 checkstyle 1m 20s master passed
+1 💚 shadedjars 4m 39s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s master passed
+0 🆗 spotbugs 4m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 6s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 3s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 checkstyle 1m 19s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 36s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 15m 31s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 37s the patch passed
+1 💚 findbugs 4m 8s the patch passed
_ Other Tests _
-1 ❌ unit 167m 23s hbase-server in the patch failed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
224m 12s
Reason Tests
Failed junit tests hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk
hadoop.hbase.replication.TestReplicationDroppedTables
hadoop.hbase.master.TestClusterRestartFailover
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile
GITHUB PR #202
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d9f62458b8d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revision master / 4ea7922
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/
Max. process+thread count 5054 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@carp84
Copy link
Member

carp84 commented Dec 5, 2019

From the latest UT result I could see below failure/error, please double check whether they're related to changes here @binlijin . Thanks.

[ERROR] Failures:
[ERROR] TestClusterRestartFailover.test:111 Submit the SCP for the same serverName d9f62458b8d2,42889,1574347120113 which should fail
[ERROR] TestClusterRestartFailoverSplitWithoutZk>TestClusterRestartFailover.test:111 Submit the SCP for the same serverName d9f62458b8d2,38945,1574346611108 which should fail
[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.replication.TestReplicationDroppedTables.org.apache.hadoop.hbase.replication.TestReplicationDroppedTables
[ERROR] Run 1: TestReplicationDroppedTables.testEditsDroppedWithDroppedTableNS:132->testEditsBehindDroppedTable:186 » TestTimedOut
[ERROR] Run 2: TestReplicationDroppedTables.org.apache.hadoop.hbase.replication.TestReplicationDroppedTables »

@binlijin
Copy link
Contributor Author

binlijin commented Dec 5, 2019

@carp84 run this tests and passed locally, they're not related to the patch.

Copy link
Member

@carp84 carp84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation, then everything LGTM, +1.

@binlijin binlijin merged commit dff7fff into apache:master Dec 9, 2019
asfgit pushed a commit that referenced this pull request Dec 9, 2019
asfgit pushed a commit that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants