HBASE-24199 Procedure related metrics is not consumed in the JMX metric #1616

gkanade · 2020-04-30T11:47:15Z

Modified getApi call in Metrics implementations to expose metrics
registered in new registry as well

Modified getApi call in Metrics implementations to expose metrics registered in new registry as well

Apache-HBase · 2020-04-30T12:25:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s	master passed
+1 💚	checkstyle	1m 21s	master passed
+1 💚	spotbugs	2m 29s	master passed
-0 ⚠️	patch	2m 14s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s	the patch passed
-0 ⚠️	checkstyle	1m 6s	hbase-server: The patch generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 59s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 47s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		34m 50s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1616
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux fc559a1204fd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `512d00e`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-30T14:19:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	1m 24s	master passed
+1 💚	shadedjars	5m 5s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 38s	hbase-server in master failed.
-0 ⚠️	patch	6m 27s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	5m 5s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 39s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	121m 46s	hbase-server in the patch passed.
		148m 47s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1616
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9b7d1eef86e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `512d00e`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/testReport/
Max. process+thread count	4625 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-30T14:33:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	master passed
-0 ⚠️	patch	6m 26s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	1m 17s	the patch passed
+1 💚	javac	1m 17s	the patch passed
+1 💚	shadedjars	5m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 34s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	137m 28s	hbase-server in the patch passed.
		163m 27s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1616
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 079f98ec98a1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `512d00e`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/testReport/
Max. process+thread count	3750 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-01T05:17:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 51s	master passed
+1 💚	checkstyle	1m 25s	master passed
+1 💚	spotbugs	2m 35s	master passed
-0 ⚠️	patch	2m 19s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	checkstyle	1m 23s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		37m 32s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1616
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 2b2313bab883 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `512d00e`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-01T07:28:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 19s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	5m 22s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
-0 ⚠️	patch	6m 42s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 5s	the patch passed
+1 💚	compile	1m 26s	the patch passed
+1 💚	javac	1m 26s	the patch passed
+1 💚	shadedjars	5m 28s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 23s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 40s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	139m 17s	hbase-server in the patch passed.
		167m 46s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1616
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux db12b9afc3e9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `512d00e`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/testReport/
Max. process+thread count	3916 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-01T07:34:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	4m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	master passed
-0 ⚠️	patch	6m 9s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	4m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	149m 20s	hbase-server in the patch passed.
		174m 43s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1616
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ed2eb91cc743 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `512d00e`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/testReport/
Max. process+thread count	3741 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1616/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…ic (#1616) Signed-off-by: stack <stack@apache.org>

…ic (#1616) Addendum; fix failing test

…ic (apache#1616) Signed-off-by: stack <stack@apache.org>

…ic (apache#1616) Signed-off-by: stack <stack@apache.org> (cherry picked from commit aa8f222) Change-Id: I7b850a2b7b7b2c71f20e6c6451325137f18a68d2

Gaurav Kanade added 2 commits April 30, 2020 17:10

HBASE-24199

8d07cc9

Modified getApi call in Metrics implementations to expose metrics registered in new registry as well

Merge remote-tracking branch 'upstream/master' into hbase-24199

39c9bd7

fixed checkstyle issues

bb24664

saintstack merged commit 9785f5d into apache:master May 1, 2020

saintstack pushed a commit that referenced this pull request May 1, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metr…

1df3bee

…ic (#1616) Signed-off-by: stack <stack@apache.org>

saintstack pushed a commit that referenced this pull request May 1, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metr…

6147aeb

…ic (#1616) Signed-off-by: stack <stack@apache.org>

saintstack pushed a commit that referenced this pull request May 1, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metr…

aa8f222

…ic (#1616) Signed-off-by: stack <stack@apache.org>

saintstack added a commit that referenced this pull request May 2, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metr…

da92a12

…ic (#1616) Addendum; fix failing test

saintstack added a commit that referenced this pull request May 2, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metr…

b977d1f

…ic (#1616) Addendum; fix failing test

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metr…

9da5e72

…ic (apache#1616) Signed-off-by: stack <stack@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24199 Procedure related metrics is not consumed in the JMX metric #1616

HBASE-24199 Procedure related metrics is not consumed in the JMX metric #1616

gkanade commented Apr 30, 2020

Apache-HBase commented Apr 30, 2020

Apache-HBase commented Apr 30, 2020

Apache-HBase commented Apr 30, 2020

Apache-HBase commented May 1, 2020

Apache-HBase commented May 1, 2020

Apache-HBase commented May 1, 2020

HBASE-24199 Procedure related metrics is not consumed in the JMX metric #1616

HBASE-24199 Procedure related metrics is not consumed in the JMX metric #1616

Conversation

gkanade commented Apr 30, 2020

Apache-HBase commented Apr 30, 2020

Apache-HBase commented Apr 30, 2020

Apache-HBase commented Apr 30, 2020

Apache-HBase commented May 1, 2020

Apache-HBase commented May 1, 2020

Apache-HBase commented May 1, 2020