Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1624

Merged
merged 1 commit into from
May 12, 2020
Merged

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1624

merged 1 commit into from
May 12, 2020

Conversation

pankaj72981
Copy link
Contributor

maxPoolSize should be logged as a plain number.

Raising PR#1483 again for QA run.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 56s Docker failed to build yetus/hbase:d9b4982ad4.
Subsystem Report/Notes
GITHUB PR #1624
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1624/1/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

Retry build

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 1m 14s Docker failed to build yetus/hbase:d9b4982ad4.
Subsystem Report/Notes
GITHUB PR #1624
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1624/2/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Do you know why the build fails?

virajjasani
virajjasani approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani
Copy link
Contributor

Triggered one more build, let's see if build issue is resolved this time.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 1m 19s Docker failed to build yetus/hbase:d9b4982ad4.
Subsystem Report/Notes
GITHUB PR #1624
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1624/3/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

Fails because we don't have

HBASE-24251 PreCommit build is failing because of can not build docker image; addendum (#1579)

Signed-off-by: Duo Zhang <zhangduo@apache.org>

on branch-2.2?

@saintstack
Copy link
Contributor

I tried to apply to branch-2 but it won't go.

Put up a new PR against branch-2 or master?

@saintstack
Copy link
Contributor

Carry over the +1s from here to your new PR?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 57s Docker failed to build yetus/hbase:d9b4982ad4.
Subsystem Report/Notes
GITHUB PR #1624
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1624/4/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@pankaj72981
Copy link
Contributor Author

I tried to apply to branch-2 but it won't go.

Put up a new PR against branch-2 or master?

Master or branch-2 doesn't have this problem,

hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferArray.java

Line 69 in 2774510

LOG.info("Allocating buffers total={}, sizePerBuffer={}, count={}",

@saintstack saintstack merged commit 0b4f272 into apache:branch-2.2 May 12, 2020
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@pankaj72981
HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool (apac…
0ba6b8a 
…he#1624)

Signed-off-by: Jan Hentschel <janh@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 0b4f272)

Change-Id: I4500255c40cd50a82fc8a473c61606ede3a67d5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

@HorizonNet HorizonNet HorizonNet approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pankaj72981 @Apache-HBase @saintstack @virajjasani @HorizonNet