HBASE-24335 Support deleteall with ts but without column in shell mode #1668

bsglz · 2020-05-06T12:26:23Z

No description provided.

Apache-HBase · 2020-05-06T13:00:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	rubocop	0m 22s	The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		4m 41s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	dupname asflicense rubocop
uname	Linux 4234f39a969e 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4ac1719`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	47 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-06T13:15:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 3s	master passed
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 43s	the patch passed
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 57s	hbase-shell in the patch passed.
		16m 35s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 8fd7f3d44455 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4ac1719`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/testReport/
Max. process+thread count	1542 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-06T13:22:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 35s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 11s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 3s	hbase-shell in the patch passed.
		21m 48s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 18dff6709f6d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4ac1719`
Default Java	2020-01-14
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/testReport/
Max. process+thread count	1584 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil · 2020-05-06T15:05:27Z

hbase-shell/src/main/ruby/shell/commands/deleteall.rb

@@ -30,12 +30,14 @@ def help
  hbase> deleteall 't1', 'r1'
  hbase> deleteall 't1', 'r1', 'c1'
  hbase> deleteall 't1', 'r1', 'c1', ts1
+  hbase> deleteall 't1', 'r1', '', ts1        //'' means not specify column


nit: better rephrase comment as: //'' means no specific column

Maybe worth also explain that this command deletes all cells in the row which timestamp is lower than the one specified in the command.

fix, thanks for your review.

Apache-HBase · 2020-05-07T01:47:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	rubocop	0m 13s	The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		2m 8s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	dupname asflicense rubocop
uname	Linux f25dc5a1fad8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	51 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T02:01:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 57s	hbase-shell in the patch passed.
		15m 59s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 2deb3e137367 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/testReport/
Max. process+thread count	2403 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T02:04:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 38s	master passed
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 31s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 53s	hbase-shell in the patch passed.
		19m 34s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 9d713fe12622 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	2020-01-14
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/testReport/
Max. process+thread count	1599 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T03:07:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	rubocop	0m 14s	The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		2m 5s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	dupname asflicense rubocop
uname	Linux 5d3880ac7ec3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	47 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T03:21:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 52s	master passed
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 55s	hbase-shell in the patch passed.
		16m 13s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 5f4ef248f2de 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/testReport/
Max. process+thread count	1556 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T03:24:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 28s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 31s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 59s	hbase-shell in the patch passed.
		19m 24s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 60cc363c6291 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	2020-01-14
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/testReport/
Max. process+thread count	1549 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil

Looks good, just needs small english correction on the comment.

wchevreuil · 2020-05-07T11:30:58Z

hbase-shell/src/main/ruby/shell/commands/deleteall.rb

@@ -30,12 +30,16 @@ def help
  hbase> deleteall 't1', 'r1'
  hbase> deleteall 't1', 'r1', 'c1'
  hbase> deleteall 't1', 'r1', 'c1', ts1
+  //'' means no specific column, it will deletes all cells in the row which timestamp is lower than


should be it deletes or will delete, instead of it will deletes.

fix, thanks for the review and patience. : )

Apache-HBase · 2020-05-07T14:17:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	rubocop	0m 13s	The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		1m 59s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	dupname asflicense rubocop
uname	Linux 98b6fcec0901 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	47 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T14:32:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 48s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 57s	hbase-shell in the patch passed.
		16m 27s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 0d7d5fa124aa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/testReport/
Max. process+thread count	2359 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T14:33:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 38s	master passed
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 51s	hbase-shell in the patch passed.
		17m 37s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 910cd55d3120 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	2020-01-14
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/testReport/
Max. process+thread count	1545 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-shell/src/main/ruby/shell/commands/deleteall.rb

Apache-HBase · 2020-05-07T15:37:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	rubocop	0m 13s	The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		1m 59s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	dupname asflicense rubocop
uname	Linux cb75559def7c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	46 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T15:51:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 33s	master passed
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 33s	the patch passed
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 0s	hbase-shell in the patch passed.
		16m 15s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux 659e77734e26 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/testReport/
Max. process+thread count	2402 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-07T15:52:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 25s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 47s	hbase-shell in the patch passed.
		17m 22s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1668
Optional Tests	javac javadoc unit
uname	Linux fd48eb2b11e5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f4a446c`
Default Java	2020-01-14
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/testReport/
Max. process+thread count	1545 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

#1668) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 2cafe81)

apache#1668) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 2cafe81)

HBASE-24335 Support deleteall with ts but without column in shell mode

4567141

wchevreuil reviewed May 6, 2020

View reviewed changes

fix review issue

74f549c

fix describe of unit test

ae47979

wchevreuil approved these changes May 7, 2020

View reviewed changes

fix review issue

ee5a2ab

wchevreuil reviewed May 7, 2020

View reviewed changes

hbase-shell/src/main/ruby/shell/commands/deleteall.rb Outdated Show resolved Hide resolved

fix review issue

df1b7d1

wchevreuil merged commit 2cafe81 into apache:master May 7, 2020

wchevreuil pushed a commit that referenced this pull request May 7, 2020

HBASE-24335 Support deleteall with ts but without column in shell mode (

f98c0fc

#1668) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 2cafe81)

wchevreuil pushed a commit that referenced this pull request May 7, 2020

HBASE-24335 Support deleteall with ts but without column in shell mode (

9dd8c96

#1668) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 2cafe81)

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-24335 Support deleteall with ts but without column in shell mode (

5df4ec2

apache#1668) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 2cafe81)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24335 Support deleteall with ts but without column in shell mode #1668

HBASE-24335 Support deleteall with ts but without column in shell mode #1668

bsglz commented May 6, 2020

Apache-HBase commented May 6, 2020

Apache-HBase commented May 6, 2020

Apache-HBase commented May 6, 2020

wchevreuil May 6, 2020

wchevreuil May 6, 2020

bsglz May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

wchevreuil left a comment

wchevreuil May 7, 2020

bsglz May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

HBASE-24335 Support deleteall with ts but without column in shell mode #1668

HBASE-24335 Support deleteall with ts but without column in shell mode #1668

Conversation

bsglz commented May 6, 2020

Apache-HBase commented May 6, 2020

Apache-HBase commented May 6, 2020

Apache-HBase commented May 6, 2020

wchevreuil May 6, 2020

Choose a reason for hiding this comment

wchevreuil May 6, 2020

Choose a reason for hiding this comment

bsglz May 7, 2020

Choose a reason for hiding this comment

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

wchevreuil left a comment

Choose a reason for hiding this comment

wchevreuil May 7, 2020

Choose a reason for hiding this comment

bsglz May 7, 2020

Choose a reason for hiding this comment

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020

Apache-HBase commented May 7, 2020