HBASE-24361 Make RESTApiClusterManager more resilient
#1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sometimes API calls return with null/empty response bodies. thus, wrap all API calls in a retry loop. * calls that submit work in the form of "commands" now retrieve the commandId from successful command submission, and track completion of that command before returning control to calling context. * model CM's process state and use that model to guide state transitions more intelligently. this guards against, for example, the start command failing with an error message like "Role must be stopped". * improvements to logging levels, avoid spamming logs with the side-effects of retries at this and higher contexts. * include references to API documentation, such as it is.
saintstack
approved these changes
May 13, 2020
| // retaining the "Started" state but with the process marked as "unhealthy". | ||
| // Instead of blindly issuing the START command, first send a STOP command | ||
| // to ensure the START will be accepted. | ||
| LOG.debug("Performing start of {} on {}:{}", service, hostname, port); |
| + " {} state. Restarting. {}, {}:{}", currentState, service, hostname, port); | ||
| performClusterManagerCommand(service, hostname, RoleCommand.RESTART); | ||
| return; | ||
| } |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
May 19, 2020
* sometimes API calls return with null/empty response bodies. thus, wrap all API calls in a retry loop. * calls that submit work in the form of "commands" now retrieve the commandId from successful command submission, and track completion of that command before returning control to calling context. * model CM's process state and use that model to guide state transitions more intelligently. this guards against, for example, the start command failing with an error message like "Role must be stopped". * improvements to logging levels, avoid spamming logs with the side-effects of retries at this and higher contexts. * include references to API documentation, such as it is. Signed-off-by: stack <stack@apache.org>
ndimiduk
added a commit
that referenced
this pull request
May 19, 2020
* sometimes API calls return with null/empty response bodies. thus, wrap all API calls in a retry loop. * calls that submit work in the form of "commands" now retrieve the commandId from successful command submission, and track completion of that command before returning control to calling context. * model CM's process state and use that model to guide state transitions more intelligently. this guards against, for example, the start command failing with an error message like "Role must be stopped". * improvements to logging levels, avoid spamming logs with the side-effects of retries at this and higher contexts. * include references to API documentation, such as it is. Signed-off-by: stack <stack@apache.org>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
May 19, 2020
* sometimes API calls return with null/empty response bodies. thus, wrap all API calls in a retry loop. * calls that submit work in the form of "commands" now retrieve the commandId from successful command submission, and track completion of that command before returning control to calling context. * model CM's process state and use that model to guide state transitions more intelligently. this guards against, for example, the start command failing with an error message like "Role must be stopped". * improvements to logging levels, avoid spamming logs with the side-effects of retries at this and higher contexts. * include references to API documentation, such as it is. Signed-off-by: stack <stack@apache.org>
ndimiduk
added a commit
that referenced
this pull request
May 19, 2020
* sometimes API calls return with null/empty response bodies. thus, wrap all API calls in a retry loop. * calls that submit work in the form of "commands" now retrieve the commandId from successful command submission, and track completion of that command before returning control to calling context. * model CM's process state and use that model to guide state transitions more intelligently. this guards against, for example, the start command failing with an error message like "Role must be stopped". * improvements to logging levels, avoid spamming logs with the side-effects of retries at this and higher contexts. * include references to API documentation, such as it is. Signed-off-by: stack <stack@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
* sometimes API calls return with null/empty response bodies. thus, wrap all API calls in a retry loop. * calls that submit work in the form of "commands" now retrieve the commandId from successful command submission, and track completion of that command before returning control to calling context. * model CM's process state and use that model to guide state transitions more intelligently. this guards against, for example, the start command failing with an error message like "Role must be stopped". * improvements to logging levels, avoid spamming logs with the side-effects of retries at this and higher contexts. * include references to API documentation, such as it is. Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap all API calls in a retry loop.
commandId from successful command submission, and track completion
of that command before returning control to calling context.
transitions more intelligently. this guards against, for example,
the start command failing with an error message like "Role must be
stopped".
side-effects of retries at this and higher contexts.