Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23969 Meta browser should show all info columns #1710

Merged
merged 1 commit into from May 18, 2020
Merged

HBASE-23969 Meta browser should show all info columns #1710

merged 1 commit into from May 18, 2020

Conversation

liuml07
Copy link
Member

@liuml07 liuml07 commented May 14, 2020 •
edited

https://issues.apache.org/jira/browse/HBASE-23969

The code was based on #1485 The conflict in table.jsp between master and branch-2 mainly comes from Java/HTML indentation. So this PR is update following the branch-2 indentation.

@liuml07
Copy link
Member Author

liuml07 commented May 14, 2020

Screen Shot 2020-05-14 at 12 27 13 AM

@liuml07
Copy link
Member Author

liuml07 commented May 14, 2020

@ndimiduk Taking a look? Thanks!

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 32s branch-2 passed
+1 💚 checkstyle 2m 45s branch-2 passed
+1 💚 spotbugs 5m 1s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 9s the patch passed
+1 💚 checkstyle 0m 27s The patch passed checkstyle in hbase-common
-0 ⚠️ checkstyle 0m 36s hbase-client: The patch generated 2 new + 51 unchanged - 0 fixed = 53 total (was 51)
+1 💚 checkstyle 1m 23s hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 14m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 5m 41s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
52m 6s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1710
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux e1fb2c1b3273 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 941cef7
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 42s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 21s branch-2 passed
+1 💚 compile 2m 7s branch-2 passed
+1 💚 shadedjars 6m 7s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 34s hbase-client in branch-2 failed.
-0 ⚠️ javadoc 0m 17s hbase-common in branch-2 failed.
-0 ⚠️ javadoc 0m 38s hbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
+1 💚 shadedjars 6m 16s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 29s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 42s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 1m 55s hbase-common in the patch passed.
+1 💚 unit 2m 36s hbase-client in the patch passed.
+1 💚 unit 136m 28s hbase-server in the patch passed.
173m 48s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1710
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9c05f10b6677 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 941cef7
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/testReport/
Max. process+thread count 3792 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 42s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 39s branch-2 passed
+1 💚 compile 1m 48s branch-2 passed
+1 💚 shadedjars 5m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 24s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 38s the patch passed
+1 💚 compile 1m 41s the patch passed
+1 💚 javac 1m 41s the patch passed
+1 💚 shadedjars 5m 9s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 19s the patch passed
_ Other Tests _
+1 💚 unit 1m 24s hbase-common in the patch passed.
+1 💚 unit 2m 14s hbase-client in the patch passed.
+1 💚 unit 147m 35s hbase-server in the patch passed.
179m 55s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1710
Optional Tests javac javadoc unit shadedjars compile
uname Linux f5a2e1f3be04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 941cef7
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/testReport/
Max. process+thread count 3580 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1710/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the backport!

@ndimiduk ndimiduk merged commit 5893c4f into apache:branch-2 May 18, 2020
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request May 18, 2020
@liuml07 @ndimiduk
HBASE-23969 Meta browser should show all info columns (apache#1710)
8813610 
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
ndimiduk pushed a commit that referenced this pull request May 18, 2020
@liuml07 @ndimiduk
HBASE-23969 Meta browser should show all info columns (#1710)
36a8e85 
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@liuml07
Copy link
Member Author

liuml07 commented May 18, 2020

Thank you @ndimiduk !

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@liuml07 @clarax
HBASE-23969 Meta browser should show all info columns (apache#1710)
a5a0451 
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@liuml07 @Apache-HBase @ndimiduk