-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24379 CatalogJanitor misreports region holes when there are act… #1741
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
cbedc44
to
21d3744
Compare
I run the failed test locally and it passed. The test case timed out, I am kicking off another run. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we try more combos here Huaxiang? I think this will get one case for sure but what happens if:
[a, g), [bb, cc), [dd, ee)
... will we report hole between a-bb or cc-dd or ee-g ?
Or will it just show as overlap?
Otherwise +1.
Or rather, while we are in here, maybe add some more test cases since they cheap to do. |
Thanks Stack. Yeah, they will be reported as overlaps. In this case, g is the region with highest key and it overlaps with the other two regions. The algorithm reporting holes only has one corner case which is fixed in this patch. I will add more test cases. |
21d3744
to
0c075ec
Compare
Add more test case, updated the patch. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
The test failure is HBASE-23976 (seems that it still happens). |
…ually over laps. (apache#1741) Signed-off-by: stack <stack@apache.org>
…ually over laps. (apache#1741) Signed-off-by: stack <stack@apache.org>
…ually over laps. (apache#1741) Signed-off-by: stack <stack@apache.org>
…ually over laps. (apache#1741) (apache#1785) Signed-off-by: stack <stack@apache.org>
…ually over laps. (apache#1741) (apache#1776) Signed-off-by: stack <stack@apache.org>
…ually over laps. (apache#1741) (apache#1777) Signed-off-by: stack <stack@apache.org>
…ually over laps. (apache#1741) (apache#1785) Author: huaxiangsun Reason: Bug Ref: CDPD-15964 Signed-off-by: stack <stack@apache.org> Change-Id: Ic77366213b962dc28c428ac57dcdc19d5c2287f1 (cherry picked from commit b850603)
…ually over laps. (apache#1741) (apache#1785) Signed-off-by: stack <stack@apache.org> (cherry picked from commit 482956e) Change-Id: Ic77366213b962dc28c428ac57dcdc19d5c2287f1
…ually over laps.