HBASE-24401 Cell size limit check on append should consider 0 or less… #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
May 20, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Show resolved
Hide resolved
wchevreuil
reviewed
May 20, 2020
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide5.java
Outdated
Show resolved
Hide resolved
wchevreuil
reviewed
May 20, 2020
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
May 20, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
reviewed
May 20, 2020
| @@ -2274,6 +2274,21 @@ public void testCellSizeLimit() throws IOException { | |||
| // expected | |||
| } | |||
| } | |||
| //test cell size no limit | |||
| final TableName noLimitTable = TableName.valueOf("testCellSizeNoLimit"); | |||
There was a problem hiding this comment.
Use the @Rule provided in this class instead of a String for the table name, such as name.getMethodName().
There was a problem hiding this comment.
Good suggestion, done.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
May 21, 2020
| } | ||
| throw new DoNotRetryIOException(msg); | ||
| } else { | ||
| LOG.debug("Cell size check is disabled because of maxCellSize is set to {}.", |
There was a problem hiding this comment.
Don't need to log this everytime? Only log once is enough when regionserver start.
There was a problem hiding this comment.
This parameter can be configured to the column family of the table, different tables can have different values.
There was a problem hiding this comment.
ok. I thought this log is not needed. If log this everytime, there are too many logs.
There was a problem hiding this comment.
This log may be not very helpful, @wchevreuil what do you think ?
There was a problem hiding this comment.
I removed this log, because there may be too many logs and not very helpful.
There was a problem hiding this comment.
I removed this log, because there may be too many logs and not very helpful.
Well, that's why I suggested it to be DEBUG. Logging it only once may not be sufficient in cases where log rolls too quickly.
There was a problem hiding this comment.
Well, that's why I suggested it to be DEBUG. Logging it only once may not be sufficient in cases where log rolls too quickly.
We could check it in the regionserver configuration and table desc. It ’s OK to remove this log?
There was a problem hiding this comment.
Many users and even experienced developers may not be aware of this changed behaviour. When things don't seem to work as expected, and one doesn't have an idea about why, decreasing the log level to gather as much info as possible is a common practice. I know it would be verbose, but that's why we should make it either a DEBUG or a TRACE level message. The message then would give a clear clue for those who didn't even know about the config property or table attribute.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
May 21, 2020
| throw new DoNotRetryIOException(msg); | ||
| } | ||
| } | ||
| } else { | ||
| LOG.debug("Cell size check is disabled because of maxCellSize is set to {}.", r.maxCellSize); |
There was a problem hiding this comment.
Removed this log.
or less value to disable the check
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
approved these changes
May 22, 2020
asfgit
pushed a commit
that referenced
this pull request
May 25, 2020
… value to disable the check (#1742) Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit
pushed a commit
that referenced
this pull request
May 25, 2020
… value to disable the check (#1742) Signed-off-by: Guanghao Zhang <zghao@apache.org>
|
Thanks for the reviews all. |
asfgit
pushed a commit
that referenced
this pull request
May 25, 2020
… value to disable the check (#1742) Signed-off-by: Guanghao Zhang <zghao@apache.org>
HomminLee
pushed a commit
to HomminLee/hbase
that referenced
this pull request
Jun 12, 2020
… value to disable the check (apache#1742) Signed-off-by: Guanghao Zhang <zghao@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
… value to disable the check (apache#1742) Signed-off-by: Guanghao Zhang <zghao@apache.org>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
… value to disable the check (apache#1742) Signed-off-by: Guanghao Zhang <zghao@apache.org> (cherry picked from commit 3cd1525) Change-Id: I08c6a619621107ee5b1c996c3ee5971b968f333e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… value to disable the check