HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format #1749

apurtell · 2020-05-20T20:54:54Z

No description provided.

apurtell · 2020-05-20T20:56:10Z

Log the elapsed time in milliseconds, which operators will be more used to dealing with than nanosecond measures.

Remove the log lines for the average time, which is not interesting, and can be derived from logs using any of the common solutions for log scraping that operators will use.

Log at DEBUG level instead of INFO.

I agree with @ndimiduk that a histogram might be better, but it should be exported as a real metric, not dumped in logs, in that case. Added a TODO in that regard.

Apache-HBase · 2020-05-20T21:28:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 42s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	5m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	shadedjars	5m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 22s	hbase-common in the patch passed.
		22m 47s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e32fc3bad7e7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `86a2692`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/testReport/
Max. process+thread count	340 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-20T21:29:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 18s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	shadedjars	5m 46s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-common in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-common in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 22s	hbase-common in the patch passed.
		24m 27s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a7bf1a4ce49d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `86a2692`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/testReport/
Max. process+thread count	279 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-20T21:34:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 46s	master passed
+1 💚	checkstyle	0m 27s	master passed
+1 💚	spotbugs	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
-0 ⚠️	checkstyle	0m 23s	hbase-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 14s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		28m 26s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 0871baef1a14 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `86a2692`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java

ndimiduk · 2020-05-22T19:27:20Z

hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java

            chore();
-            return null;
-          });
-          if (LOG.isInfoEnabled() && (System.nanoTime() - lastLog > FIVE_MINUTES_IN_NANOS)) {


Do we want some duration threshold that triggers escalating the log level to info (or warn), as was done before?

Not opposed to the idea at all, but it's going to depend on the chore, right?

yeah i think you're right. let's leave it for now.

ndimiduk · 2020-05-22T19:29:09Z

My original thinking was that we'd want to log a time with dynamic units, calculated based on the magnitude of the value. Your argument for logging durations using a fixed unit, one that can be automatically extracted by log indexing system, is a good one. Maybe one day we'll have a structured logging implementation that can accommodate both use cases.

ndimiduk · 2020-05-29T20:36:41Z

You have a new patch for us, master @apurtell ?

Apache-HBase · 2020-06-04T01:18:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 44s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	shadedjars	6m 25s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-common in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	6m 23s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 15s	hbase-common in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
		27m 30s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux eb3341f8bcc4 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60c9ae5`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/testReport/
Max. process+thread count	200 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-04T01:19:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	shadedjars	6m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
+1 💚	shadedjars	6m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
		28m 13s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 475dd7ef5dd9 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60c9ae5`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/testReport/
Max. process+thread count	222 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-04T01:25:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 11s	master passed
+1 💚	checkstyle	0m 27s	master passed
+1 💚	spotbugs	0m 50s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
-0 ⚠️	checkstyle	0m 23s	hbase-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		34m 41s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 458a1b4fe89c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60c9ae5`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

apurtell · 2020-06-05T17:16:31Z

No new patch yet. Sorry, have been away doing other things. Apologies for the noise after rebase.

…ormat

apurtell · 2020-06-05T17:25:16Z

Push just now addresses review feedback and fixes the checkstyle warning.

Apache-HBase · 2020-06-05T18:16:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	checkstyle	0m 24s	master passed
+1 💚	spotbugs	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	checkstyle	0m 22s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 54s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		32m 8s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 52f3987a272b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `89b7b5a`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-05T18:21:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 15s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	shadedjars	5m 46s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-common in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-common in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 24s	hbase-common in the patch passed.
		24m 28s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 74a8f78c7cf6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `89b7b5a`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/testReport/
Max. process+thread count	268 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-05T18:23:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 48s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	7m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 52s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	7m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 39s	hbase-common in the patch passed.
		30m 17s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1749
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1d6f7e81f8f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `89b7b5a`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/testReport/
Max. process+thread count	339 (vs. ulimit of 12500)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk

LGTM, +1

infraio

+1

virajjasani

+1

…ormat (#1749) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Guanghao Zhang <zghao@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

…ormat (apache#1749) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Guanghao Zhang <zghao@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

…ormat (apache#1749) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Guanghao Zhang <zghao@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit a5a45e8) Change-Id: Iafa735e50353b5fa07a3c79d2747a7cb18320082

apurtell requested a review from ndimiduk May 20, 2020 20:55

infraio reviewed May 21, 2020

View reviewed changes

hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java Show resolved Hide resolved

ndimiduk approved these changes May 22, 2020

View reviewed changes

apurtell force-pushed the HBASE-24367 branch from 068b54c to 414d4a8 Compare June 4, 2020 00:41

HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly f…

555db02

…ormat

apurtell force-pushed the HBASE-24367 branch from 414d4a8 to 555db02 Compare June 5, 2020 17:25

ndimiduk approved these changes Jun 5, 2020

View reviewed changes

infraio approved these changes Jun 8, 2020

View reviewed changes

infraio added the enhancement label Jun 8, 2020

virajjasani approved these changes Jun 9, 2020

View reviewed changes

apurtell merged commit 474d200 into apache:master Jun 9, 2020

apurtell deleted the HBASE-24367 branch June 9, 2020 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format #1749

HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format #1749

apurtell commented May 20, 2020

apurtell commented May 20, 2020 •

edited

Apache-HBase commented May 20, 2020

Apache-HBase commented May 20, 2020

Apache-HBase commented May 20, 2020

ndimiduk May 22, 2020

apurtell May 22, 2020

ndimiduk Jun 4, 2020

ndimiduk commented May 22, 2020

ndimiduk commented May 29, 2020

Apache-HBase commented Jun 4, 2020

Apache-HBase commented Jun 4, 2020

Apache-HBase commented Jun 4, 2020

apurtell commented Jun 5, 2020

apurtell commented Jun 5, 2020

Apache-HBase commented Jun 5, 2020

Apache-HBase commented Jun 5, 2020

Apache-HBase commented Jun 5, 2020

ndimiduk left a comment

infraio left a comment

virajjasani left a comment

HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format #1749

HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format #1749

Conversation

apurtell commented May 20, 2020

apurtell commented May 20, 2020 • edited

Apache-HBase commented May 20, 2020

Apache-HBase commented May 20, 2020

Apache-HBase commented May 20, 2020

ndimiduk May 22, 2020

Choose a reason for hiding this comment

apurtell May 22, 2020

Choose a reason for hiding this comment

ndimiduk Jun 4, 2020

Choose a reason for hiding this comment

ndimiduk commented May 22, 2020

ndimiduk commented May 29, 2020

Apache-HBase commented Jun 4, 2020

Apache-HBase commented Jun 4, 2020

Apache-HBase commented Jun 4, 2020

apurtell commented Jun 5, 2020

apurtell commented Jun 5, 2020

Apache-HBase commented Jun 5, 2020

Apache-HBase commented Jun 5, 2020

Apache-HBase commented Jun 5, 2020

ndimiduk left a comment

Choose a reason for hiding this comment

infraio left a comment

Choose a reason for hiding this comment

virajjasani left a comment

Choose a reason for hiding this comment

apurtell commented May 20, 2020 •

edited