HBASE-21406 "status 'replication'" should not show SINK if the cluste… #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r does not act as sink
wchevreuil
requested review from
busbey,
joshelser,
HorizonNet,
petersomogyi and
virajjasani
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
May 22, 2020
| assertEquals(loadSink.getTimestampStarted(), loadSink.getTimestampsOfLastAppliedOp()); | ||
| //now insert some rows on source, so that it gets delivered to target | ||
| insertRowsOnSource(); | ||
| Thread.sleep(10000); |
There was a problem hiding this comment.
Although 10s seems more than enough time, we can use Waiter.wait() / HBASE_TESTING_UTILITY.waitFor() with predicate to check if loadSink.getTimestampsOfLastAppliedOp()>loadSink.getTimestampStarted().
| } | ||
|
|
||
| /** | ||
| * Gets the total number of OPs delivered to target by this sink. |
There was a problem hiding this comment.
nit: Gets the total number of OPs delivered to this sink would be better? WDYT?
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
May 24, 2020
| //now insert some rows on source, so that it gets delivered to target | ||
| insertRowsOnSource(); | ||
| long wait = Waiter.waitFor(UTIL2.getConfiguration(), | ||
| 100000, new Waiter.Predicate<Exception>() { |
There was a problem hiding this comment.
Want to keep it 10s instead of 100s? :)
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
HorizonNet
approved these changes
May 27, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSink.java
Outdated
Show resolved
Hide resolved
joshelser
approved these changes
May 28, 2020
joshelser
approved these changes
Jun 1, 2020
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
apache#1761) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (Cherry picked from commit e5345b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r does not act as sink