HBASE-24425 Run hbck_chore_run and catalogjanitor_run on draw of 'HBC… #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
May 25, 2020
| <% | ||
| final String cacheParameterValue = request.getParameter("cache"); | ||
| boolean cache = Boolean.valueOf(cacheParameterValue); |
There was a problem hiding this comment.
nit: Since we need boolean, we can directly use: Boolean.parseBoolean(cacheParameterValue)
| if (!cache) { | ||
| // Run the two reporters inline w/ drawing of the page. If exception, will show in page draw. | ||
| master.getMasterRpcServices().runHbckChore(null, null); | ||
| master.getMasterRpcServices().runCatalogScan(null, null); |
There was a problem hiding this comment.
MasterRpcServices throw ServiceException for both runHbckChore and runCatalogScan. Maybe we can handle it and print some nice error message?
There was a problem hiding this comment.
Yeah. Was thinking about it. Though the rare SE not the end of the world. Added something at your prompting.... it looks like this when generated...
if (!Boolean.parseBoolean(cacheParameterValue)) {
// Run the two reporters inline w/ drawing of the page. If exception, will show in page draw.
try {
master.getMasterRpcServices().runHbckChore(null, null);
} catch (org.apache.hbase.thirdparty.com.google.protobuf.ServiceException se) {
out.write("Failed generating a new hbck_chore report; using cache; try again or run hbck_chore_run in the shell: " + se.getMessage() + "\n");
}
try {
master.getMasterRpcServices().runCatalogScan(null, null);
} catch (org.apache.hbase.thirdparty.com.google.protobuf.ServiceException se) {
out.write("Failed generating a new catalogjanitor report; using cache; try again or run catalogjanitor_run in the shell: " + se.getMessage() + "\n");
}
}
| @@ -37,9 +37,17 @@ | |||
| <%@ page import="org.apache.hadoop.hbase.util.Pair" %> | |||
| <%@ page import="org.apache.hadoop.hbase.master.CatalogJanitor" %> | |||
| <%@ page import="org.apache.hadoop.hbase.master.CatalogJanitor.Report" %> | |||
| <%@ page import="org.apache.hadoop.hbase.util.Threads" %> | |||
There was a problem hiding this comment.
Not being used it seems.
Looks like a clean apply to master and branch-2.3 👍 |
huaxiangsun
approved these changes
May 25, 2020
|
Address @virajjasani suggestions. @HorizonNet I pushed against branch-2 since that is what I know and its stable.... will forward port when all is good. Thanks for the reviews. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
clarax
approved these changes
May 27, 2020
saintstack
added a commit
that referenced
this pull request
May 27, 2020
…K Report' page (#1771) Signed-off-by: clarax Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com>
saintstack
added a commit
that referenced
this pull request
May 27, 2020
…K Report' page (#1771) Signed-off-by: clarax Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…K Report' page (apache#1771) Signed-off-by: clarax Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…K Report' page