Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24416 RegionNormalizer spliting region should not be limited by… #1788

Merged
merged 1 commit into from
May 28, 2020
Merged

HBASE-24416 RegionNormalizer spliting region should not be limited by… #1788

merged 1 commit into from
May 28, 2020

Conversation

ddupg
Copy link
Member

@ddupg ddupg commented May 27, 2020

… hbase.normalizer.min.region.count

JIRA: https://issues.apache.org/jira/browse/HBASE-24416#

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 1s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 39s branch-2.2 passed
+1 💚 compile 1m 0s branch-2.2 passed
+1 💚 checkstyle 1m 30s branch-2.2 passed
+1 💚 shadedjars 4m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s branch-2.2 passed
+0 🆗 spotbugs 3m 45s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 42s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 16s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
+1 💚 checkstyle 1m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 11s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 34s the patch passed
+1 💚 findbugs 3m 40s the patch passed
_ Other Tests _
-1 ❌ unit 307m 26s hbase-server in the patch failed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
380m 14s
Reason Tests
Failed junit tests hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/1/artifact/out/Dockerfile
GITHUB PR #1788
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5863c95dddb5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1788/out/precommit/personality/provided.sh
git revision branch-2.2 / abe5a05
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/1/testReport/
Max. process+thread count 5082 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

@ddupg multiple tests are failing. Can you please take a look once? How are they doing locally?

@ddupg
Copy link
Member Author

ddupg commented May 28, 2020

@ddupg multiple tests are failing. Can you please take a look once? How are they doing locally?

Thanks @virajjasani for taking a look here. The following is unit log, it seems like that failed UTs are unrelated with this PR.

[ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

Let me trigger UTs running again.

@infraio infraio changed the title backport: HBASE-24416 RegionNormalizer spliting region should not be limited by… HBASE-24416 RegionNormalizer spliting region should not be limited by… May 28, 2020
@infraio infraio added the backport This PR is a back port of some issue or issues already committed to master label May 28, 2020
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 14s branch-2.2 passed
+1 💚 compile 0m 56s branch-2.2 passed
+1 💚 checkstyle 1m 20s branch-2.2 passed
+1 💚 shadedjars 4m 9s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s branch-2.2 passed
+0 🆗 spotbugs 3m 19s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 17s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 48s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
+1 💚 checkstyle 1m 17s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 25m 27s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 34s the patch passed
+1 💚 findbugs 3m 14s the patch passed
_ Other Tests _
-1 ❌ unit 163m 50s hbase-server in the patch failed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
226m 55s
Reason Tests
Failed junit tests hadoop.hbase.TestZooKeeper
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/2/artifact/out/Dockerfile
GITHUB PR #1788
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux bfaa4b984eb0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1788/out/precommit/personality/provided.sh
git revision branch-2.2 / 482956e
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/2/testReport/
Max. process+thread count 4667 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1788/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comment, looks good otherwise

...e-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
if (tableRegions.size() < minRegionCount) {
LOG.debug("Table " + table + " has " + tableRegions.size() + " regions, required min number"
+ " of regions for normalizer merging to run is " + minRegionCount
+ ", not running normalizer merging");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to use parameters with {} for variables.

@infraio infraio merged commit 37b8064 into apache:branch-2.2 May 28, 2020
@ddupg ddupg deleted the HBASE-24416-branch2 branch May 28, 2020 08:31
HomminLee pushed a commit to HomminLee/hbase that referenced this pull request Jun 12, 2020
@ddupg @HomminLee
HBASE-24416 RegionNormalizer spliting region should not be limited by…
142f354 
… hbase.normalizer.min.region.count (apache#1788)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees

@ddupg ddupg

Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
4 participants
@ddupg @Apache-HBase @virajjasani @infraio