Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24488 Update docs re: ZooKeeper compatibility of 2.3.x release #1827

Merged
merged 1 commit into from Jun 2, 2020
Merged

HBASE-24488 Update docs re: ZooKeeper compatibility of 2.3.x release #1827

merged 1 commit into from Jun 2, 2020

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 1, 2020

Add a note to the 2.3 upgrade section regarding the ZooKeeper version
bump and include a link off to ZooKeeper's FAQ.

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 1, 2020

https://hbase.apache.org/book.html#zookeeper.requirements says "ZooKeeper 3.4.x is required." without context of either HBase version or feature that demands that version. Seems we should say more.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 36s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1827
Optional Tests
uname Linux c77a9e3c0aa1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 716702a
Max. process+thread count 47 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 16s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1827
Optional Tests
uname Linux 758edea1a21b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 716702a
Max. process+thread count 44 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 1, 2020

Did some archeology and learned about HBASE-16598.

@ndimiduk
HBASE-24488 Update docs re: ZooKeeper compatibility of 2.3.x release
b705f88 
Add a note to the 2.3 upgrade section regarding the ZooKeeper version
bump and include a link off to ZooKeeper's FAQ.
@ndimiduk ndimiduk force-pushed the 24488-2.3-upgrade-doc-zookeeper branch from 8127309 to b705f88 Compare June 1, 2020 23:14
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 46s master passed
+0 🆗 refguide 4m 48s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 4m 51s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
19m 8s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1827
Optional Tests dupname asflicense refguide
uname Linux 6588853f2b4f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 716702a
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 78 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 35s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1827
Optional Tests
uname Linux 2bad30dbed4c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 716702a
Max. process+thread count 47 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 8s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1827
Optional Tests
uname Linux e6e71160b2d5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 716702a
Max. process+thread count 43 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 44s master passed
+0 🆗 refguide 4m 59s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 18s the patch passed
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+0 🆗 refguide 4m 59s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
19m 21s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1827
Optional Tests dupname asflicense refguide
uname Linux 3160e8155625 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 716702a
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 57 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1827/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 2, 2020

PR test failure looks like more flakiness from TestExportSnapshot. I added the log and a little analysis to HBASE-24131.

@ndimiduk ndimiduk merged commit a8b3cad into apache:master Jun 2, 2020
@ndimiduk ndimiduk deleted the 24488-2.3-upgrade-doc-zookeeper branch June 2, 2020 16:42
@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 2, 2020

Thanks for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

@Apache9 Apache9 Apache9 approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ndimiduk @Apache-HBase @HorizonNet @Apache9 @virajjasani