Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24491 Remove HRegionInfo #1830

Merged
merged 2 commits into from
Jun 5, 2020
Merged

HBASE-24491 Remove HRegionInfo #1830

merged 2 commits into from
Jun 5, 2020

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jun 2, 2020

No description provided.

@Apache9 Apache9 self-assigned this Jun 2, 2020
@Apache9
Copy link
Contributor Author

Apache9 commented Jun 2, 2020

Could pass compile. Let's see the UTs.

And I guess we also need to deal with hbase-shell.

Will take a look soon.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 3m 42s master passed
+1 💚 checkstyle 3m 27s master passed
+1 💚 spotbugs 5m 45s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 34s the patch passed
+1 💚 checkstyle 0m 31s hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 2 new + 761 unchanged - 34 fixed = 763 total (was 795)
+1 💚 checkstyle 0m 19s hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)
+1 💚 checkstyle 0m 39s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 15s hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 46s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 8m 28s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 9s The patch does not generate ASF License warnings.
53m 20s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1830
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux a039e0fce97e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e5345b3
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 3m 39s master passed
+1 💚 compile 3m 15s master passed
+1 💚 shadedjars 5m 42s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 28s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 28s the patch passed
+1 💚 compile 3m 13s the patch passed
+1 💚 javac 3m 13s the patch passed
+1 💚 shadedjars 5m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 22s the patch passed
_ Other Tests _
+1 💚 unit 1m 1s hbase-client in the patch passed.
-1 ❌ unit 6m 36s hbase-server in the patch failed.
+1 💚 unit 13m 24s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 46s hbase-thrift in the patch passed.
+1 💚 unit 0m 59s hbase-it in the patch passed.
+1 💚 unit 3m 12s hbase-rest in the patch passed.
63m 29s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2bbf8effd6dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e5345b3
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/testReport/
Max. process+thread count 5415 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 4m 11s master passed
+1 💚 compile 3m 28s master passed
+1 💚 shadedjars 5m 40s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 28s hbase-client in master failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 21s hbase-rest in master failed.
-0 ⚠️ javadoc 0m 38s hbase-server in master failed.
-0 ⚠️ javadoc 0m 51s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 3m 32s the patch passed
+1 💚 javac 3m 32s the patch passed
+1 💚 shadedjars 5m 37s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 26s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 39s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 0m 51s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 21s hbase-rest in the patch failed.
_ Other Tests _
+1 💚 unit 1m 5s hbase-client in the patch passed.
-1 ❌ unit 7m 3s hbase-server in the patch failed.
+1 💚 unit 12m 11s hbase-mapreduce in the patch passed.
+1 💚 unit 3m 42s hbase-thrift in the patch passed.
+1 💚 unit 0m 54s hbase-it in the patch passed.
+1 💚 unit 2m 59s hbase-rest in the patch passed.
64m 1s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux a5cf0a47be0a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e5345b3
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/testReport/
Max. process+thread count 6032 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack reviewed Jun 2, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. So far, it looks really good.

infraio
infraio reviewed Jun 3, 2020
View reviewed changes
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java Outdated
@@ -2345,14 +2345,6 @@ public static TableName toTableName(HBaseProtos.TableName tableNamePB) {
.setQualifier(UnsafeByteOperations.unsafeWrap(tableName.getQualifier())).build();
}

public static HBaseProtos.RegionInfo toProtoRegionInfo(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore? This seems not releated to HRegionInfo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two toRegionInfo methods for converting from RegionInfo to proto and vice versa. This method is not used and the implementation is wrong, so just remove it.

infraio
infraio approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Great cleanup.

@infraio
Copy link
Contributor

infraio commented Jun 3, 2020

Seems the ut was not trigger in previous HBase QA?

@Apache9
Copy link
Contributor Author

Apache9 commented Jun 3, 2020

Seems the ut was not trigger in previous HBase QA?

There are failurs for small tests so the medium and large tests are skipped. Let me take a look.

@Apache9
Copy link
Contributor Author

Apache9 commented Jun 3, 2020

The method too long checkstyle warning is not introduced by the PR here.

Can open a follow on issue to remove HBaseTestCase and rewrite TestHStoreFile.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 3m 25s master passed
+1 💚 checkstyle 3m 27s master passed
+1 💚 spotbugs 5m 39s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 checkstyle 0m 30s hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)
-0 ⚠️ checkstyle 1m 16s hbase-server: The patch generated 1 new + 761 unchanged - 34 fixed = 762 total (was 795)
+1 💚 checkstyle 0m 18s hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)
+1 💚 checkstyle 0m 40s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 15s hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 43s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 8m 21s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 13s The patch does not generate ASF License warnings.
52m 47s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1830
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux dcae7d50b6f6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f71f1cd
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 3m 24s master passed
+1 💚 compile 3m 15s master passed
+1 💚 shadedjars 5m 31s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 26s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 26s the patch passed
+1 💚 compile 3m 8s the patch passed
+1 💚 javac 3m 8s the patch passed
+1 💚 shadedjars 5m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 20s the patch passed
_ Other Tests _
+1 💚 unit 1m 1s hbase-client in the patch passed.
-1 ❌ unit 144m 10s hbase-server in the patch failed.
+1 💚 unit 13m 28s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 56s hbase-thrift in the patch passed.
+1 💚 unit 1m 8s hbase-it in the patch passed.
+1 💚 unit 3m 21s hbase-rest in the patch passed.
201m 52s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux 38d42fbedfab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f71f1cd
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/testReport/
Max. process+thread count 5447 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s master passed
+1 💚 checkstyle 3m 38s master passed
+1 💚 spotbugs 5m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 28s the patch passed
+1 💚 checkstyle 0m 31s hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 1 new + 761 unchanged - 34 fixed = 762 total (was 795)
+1 💚 checkstyle 0m 19s hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)
+1 💚 checkstyle 0m 57s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 10s The patch passed checkstyle in hbase-shell
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 17s hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
-0 ⚠️ rubocop 0m 13s The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 38s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 8m 27s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 29s The patch does not generate ASF License warnings.
54m 8s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1830
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
uname Linux b85dcf58638e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f71f1cd
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jun 3, 2020

The failed UT is caused by a serious problem of our RegionInfo related API.

Let me open a new issue for fixing it.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s master passed
+1 💚 compile 3m 38s master passed
+1 💚 shadedjars 5m 43s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 40s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 26s the patch passed
+1 💚 compile 3m 35s the patch passed
+1 💚 javac 3m 35s the patch passed
+1 💚 shadedjars 5m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 33s the patch passed
_ Other Tests _
+1 💚 unit 1m 1s hbase-client in the patch passed.
-1 ❌ unit 144m 56s hbase-server in the patch failed.
+1 💚 unit 13m 21s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 55s hbase-thrift in the patch passed.
+1 💚 unit 7m 29s hbase-shell in the patch passed.
+1 💚 unit 1m 11s hbase-it in the patch passed.
+1 💚 unit 3m 24s hbase-rest in the patch passed.
211m 58s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux ef7dfc7aa1cf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f71f1cd
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/testReport/
Max. process+thread count 5566 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 4m 52s master passed
+1 💚 compile 4m 0s master passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 27s hbase-client in master failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 19s hbase-rest in master failed.
-0 ⚠️ javadoc 0m 41s hbase-server in master failed.
-0 ⚠️ javadoc 0m 58s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 31s the patch passed
+1 💚 compile 4m 3s the patch passed
+1 💚 javac 4m 3s the patch passed
+1 💚 shadedjars 6m 26s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 19s hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 0m 58s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-rest in the patch failed.
_ Other Tests _
+1 💚 unit 1m 22s hbase-client in the patch passed.
-1 ❌ unit 214m 12s hbase-server in the patch failed.
+1 💚 unit 45m 12s hbase-mapreduce in the patch passed.
+1 💚 unit 10m 27s hbase-thrift in the patch passed.
+1 💚 unit 10m 41s hbase-shell in the patch passed.
+1 💚 unit 1m 5s hbase-it in the patch passed.
+1 💚 unit 4m 25s hbase-rest in the patch passed.
332m 55s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux a80d174faa74 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f71f1cd
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/testReport/
Max. process+thread count 3682 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 5m 7s master passed
+1 💚 checkstyle 3m 51s master passed
+1 💚 spotbugs 6m 4s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 48s the patch passed
+1 💚 checkstyle 0m 30s hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)
-0 ⚠️ checkstyle 1m 26s hbase-server: The patch generated 1 new + 952 unchanged - 34 fixed = 953 total (was 986)
+1 💚 checkstyle 0m 19s hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)
+1 💚 checkstyle 0m 46s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 9s The patch passed checkstyle in hbase-shell
+1 💚 checkstyle 0m 15s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 15s hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
-0 ⚠️ rubocop 0m 17s The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 30s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 6m 41s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 13s The patch does not generate ASF License warnings.
58m 6s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1830
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
uname Linux 008430c31a45 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8de8c44
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 4m 35s master passed
+1 💚 compile 4m 5s master passed
+1 💚 shadedjars 7m 28s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 47s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 3m 29s the patch passed
+1 💚 javac 3m 29s the patch passed
+1 💚 shadedjars 6m 20s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 36s the patch passed
_ Other Tests _
+1 💚 unit 1m 2s hbase-client in the patch passed.
+1 💚 unit 146m 26s hbase-server in the patch passed.
-1 ❌ unit 1m 8s hbase-mapreduce in the patch failed.
+1 💚 unit 4m 20s hbase-thrift in the patch passed.
+1 💚 unit 7m 20s hbase-shell in the patch passed.
+1 💚 unit 1m 15s hbase-it in the patch passed.
+1 💚 unit 4m 21s hbase-rest in the patch passed.
205m 39s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux 17d87515a0dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8de8c44
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/testReport/
Max. process+thread count 3866 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 4m 49s master passed
+1 💚 compile 4m 19s master passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 29s hbase-client in master failed.
-0 ⚠️ javadoc 0m 22s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 23s hbase-rest in master failed.
-0 ⚠️ javadoc 0m 42s hbase-server in master failed.
-0 ⚠️ javadoc 1m 1s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 35s the patch passed
+1 💚 compile 4m 5s the patch passed
+1 💚 javac 4m 5s the patch passed
+1 💚 shadedjars 6m 32s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 27s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 41s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 1m 0s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 22s hbase-rest in the patch failed.
_ Other Tests _
+1 💚 unit 1m 26s hbase-client in the patch passed.
+1 💚 unit 202m 28s hbase-server in the patch passed.
+1 💚 unit 20m 16s hbase-mapreduce in the patch passed.
+1 💚 unit 5m 39s hbase-thrift in the patch passed.
+1 💚 unit 8m 39s hbase-shell in the patch passed.
+1 💚 unit 1m 10s hbase-it in the patch passed.
+1 💚 unit 4m 19s hbase-rest in the patch passed.
286m 45s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8c0ccb3bb870 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8de8c44
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/testReport/
Max. process+thread count 3676 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Left two minor comments.

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
@@ -350,31 +353,20 @@ public void testSplitParentFirstComparator() {
SplitParentFirstComparator comp = new SplitParentFirstComparator();
TableDescriptor td = createTableDescriptorForCurrentMethod();

/* Region splits:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep the visual representation.

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
@@ -766,15 +766,14 @@ private int getScannedCount(RegionScanner scanner) throws IOException {

/**
* Create an HRegion with the result of a WAL split and test we only see the
* good edits
* @throws Exception
* good edits=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "." instead of a "=".

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 3m 25s master passed
+1 💚 checkstyle 3m 43s master passed
+1 💚 spotbugs 5m 27s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 checkstyle 0m 27s hbase-client: The patch generated 0 new + 0 unchanged - 58 fixed = 0 total (was 58)
-0 ⚠️ checkstyle 1m 26s hbase-server: The patch generated 1 new + 952 unchanged - 33 fixed = 953 total (was 985)
+1 💚 checkstyle 0m 19s hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)
+1 💚 checkstyle 0m 42s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 12s The patch passed checkstyle in hbase-shell
+1 💚 checkstyle 0m 16s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 16s hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
-0 ⚠️ rubocop 0m 11s The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 3s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 6m 22s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 25s The patch does not generate ASF License warnings.
48m 49s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1830
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
uname Linux 61a8d019d471 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2c2b1f0
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 28s master passed
+1 💚 compile 3m 59s master passed
+1 💚 shadedjars 5m 51s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 29s hbase-client in master failed.
-0 ⚠️ javadoc 0m 24s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 20s hbase-rest in master failed.
-0 ⚠️ javadoc 0m 52s hbase-server in master failed.
-0 ⚠️ javadoc 1m 4s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 5m 7s the patch passed
+1 💚 compile 5m 2s the patch passed
+1 💚 javac 5m 2s the patch passed
+1 💚 shadedjars 8m 0s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 30s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 50s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 24s hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 1m 11s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 26s hbase-rest in the patch failed.
_ Other Tests _
+1 💚 unit 1m 25s hbase-client in the patch passed.
-1 ❌ unit 146m 57s hbase-server in the patch failed.
+1 💚 unit 11m 42s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 23s hbase-thrift in the patch passed.
+1 💚 unit 7m 10s hbase-shell in the patch passed.
+1 💚 unit 1m 7s hbase-it in the patch passed.
+1 💚 unit 3m 15s hbase-rest in the patch passed.
221m 10s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3aef661921e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2c2b1f0
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/testReport/
Max. process+thread count 5651 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 27s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for branch
+1 💚 mvninstall 4m 21s master passed
+1 💚 compile 3m 38s master passed
+1 💚 shadedjars 6m 17s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 37s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 3m 39s the patch passed
+1 💚 javac 3m 39s the patch passed
+1 💚 shadedjars 6m 16s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 35s the patch passed
_ Other Tests _
+1 💚 unit 1m 18s hbase-client in the patch passed.
+1 💚 unit 216m 31s hbase-server in the patch passed.
+1 💚 unit 20m 55s hbase-mapreduce in the patch passed.
+1 💚 unit 6m 6s hbase-thrift in the patch passed.
+1 💚 unit 7m 23s hbase-shell in the patch passed.
+1 💚 unit 1m 20s hbase-it in the patch passed.
+1 💚 unit 5m 25s hbase-rest in the patch passed.
297m 56s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux a3b45c4e6e99 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2c2b1f0
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/testReport/
Max. process+thread count 3712 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 3m 28s master passed
+1 💚 checkstyle 3m 37s master passed
+1 💚 spotbugs 5m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 19s the patch passed
+1 💚 checkstyle 0m 27s hbase-client: The patch generated 0 new + 0 unchanged - 58 fixed = 0 total (was 58)
-0 ⚠️ checkstyle 1m 25s hbase-server: The patch generated 1 new + 952 unchanged - 33 fixed = 953 total (was 985)
+1 💚 checkstyle 0m 18s hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)
+1 💚 checkstyle 0m 40s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 11s The patch passed checkstyle in hbase-shell
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 15s hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
-0 ⚠️ rubocop 0m 11s The patch generated 1 new + 166 unchanged - 1 fixed = 167 total (was 167)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 14s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 6m 32s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 18s The patch does not generate ASF License warnings.
48m 55s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1830
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
uname Linux 4e0ce252d4ac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2c2b1f0
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit c91829b into apache:master Jun 5, 2020
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 59s master passed
+1 💚 compile 3m 49s master passed
+1 💚 shadedjars 5m 42s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 26s hbase-client in master failed.
-0 ⚠️ javadoc 0m 38s hbase-server in master failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 49s hbase-thrift in master failed.
-0 ⚠️ javadoc 0m 20s hbase-rest in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 57s the patch passed
+1 💚 compile 3m 48s the patch passed
+1 💚 javac 3m 48s the patch passed
+1 💚 shadedjars 5m 42s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 0m 49s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 19s hbase-rest in the patch failed.
_ Other Tests _
+1 💚 unit 1m 11s hbase-client in the patch passed.
+1 💚 unit 132m 56s hbase-server in the patch passed.
+1 💚 unit 15m 0s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 41s hbase-thrift in the patch passed.
+1 💚 unit 7m 16s hbase-shell in the patch passed.
+1 💚 unit 1m 18s hbase-it in the patch passed.
+1 💚 unit 3m 45s hbase-rest in the patch passed.
203m 27s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0770f4012f8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2c2b1f0
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/testReport/
Max. process+thread count 5802 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 6s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s master passed
+1 💚 compile 4m 8s master passed
+1 💚 shadedjars 6m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 22s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 28s the patch passed
+1 💚 compile 3m 57s the patch passed
+1 💚 javac 3m 57s the patch passed
+1 💚 shadedjars 6m 18s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 37s the patch passed
_ Other Tests _
+1 💚 unit 1m 22s hbase-client in the patch passed.
+1 💚 unit 217m 16s hbase-server in the patch passed.
+1 💚 unit 20m 24s hbase-mapreduce in the patch passed.
+1 💚 unit 5m 45s hbase-thrift in the patch passed.
+1 💚 unit 7m 16s hbase-shell in the patch passed.
+1 💚 unit 1m 14s hbase-it in the patch passed.
+1 💚 unit 5m 34s hbase-rest in the patch passed.
300m 46s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1830
Optional Tests javac javadoc unit shadedjars compile
uname Linux ecd92f435b91 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2c2b1f0
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/testReport/
Max. process+thread count 3900 (vs. ulimit of 12500)
modules C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack left review comments

@HorizonNet HorizonNet HorizonNet approved these changes

@infraio infraio infraio approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Apache9 @Apache-HBase @infraio @saintstack @HorizonNet