Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3 #1834

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3 #1834

merged 1 commit into from
Jun 3, 2020

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 2, 2020

Simplify our Normalizer story to have just a single, configurable
implementation.

  • fold the features of MergeNormalizer into
    SimpleRegionNormalizer, removing the intermediate abstract class.
  • configuration keys for merge-only features now share a common
    structure.
  • add configuration to selectively disable normalizer split/merge
    operations.
  • RegionNormalizer now extends Configurable instead of creating a
    new instance of HBaseConfiguration or snooping one off of other
    fields.
  • avoid the extra RPCs by using MasterServices instead of
    MasterRpcServices.
  • boost test coverage of all the various flags and feature
    combinations.

Signed-off-by: Michael Stack stack@apache.org
Signed-off-by: Viraj Jasani vjasani@apache.org
Signed-off-by: huaxiangsun huaxiangsun@apache.org

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 12s root in branch-2.3 failed.
-1 ❌ compile 0m 9s root in branch-2.3 failed.
-1 ❌ shadedjars 0m 6s branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s root in branch-2.3 failed.
-0 ⚠️ javadoc 0m 14s hbase-common in branch-2.3 failed.
-0 ⚠️ javadoc 0m 23s hbase-server in branch-2.3 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 9s root in the patch failed.
-1 ❌ compile 0m 9s root in the patch failed.
-0 ⚠️ javac 0m 9s root in the patch failed.
-1 ❌ shadedjars 0m 7s patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s root in the patch failed.
-0 ⚠️ javadoc 0m 8s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 9s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 9s root in the patch failed.
4m 46s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1834
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4bf6bfb79e22 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.3 / 39e03ab
Default Java 2020-01-14
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/testReport/
Max. process+thread count 54 (vs. ulimit of 12500)
modules C: . hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk changed the title HBASE-24418 Consolidate Normalizer implementations Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3 Jun 2, 2020
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.3 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 45s branch-2.3 passed
+1 💚 checkstyle 2m 36s branch-2.3 passed
+0 🆗 refguide 12m 55s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 12m 50s branch-2.3 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 43s the patch passed
+1 💚 checkstyle 2m 38s root: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+0 🆗 refguide 7m 33s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 21m 49s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚 spotbugs 13m 34s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
92m 57s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1834
Optional Tests dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 7ab3339651d2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.3 / 39e03ab
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 138 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 14s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 50s branch-2.3 passed
+1 💚 compile 2m 58s branch-2.3 passed
+1 💚 shadedjars 6m 32s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 59s branch-2.3 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 30s the patch passed
+1 💚 compile 2m 50s the patch passed
+1 💚 javac 2m 50s the patch passed
+1 💚 shadedjars 7m 0s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 50s hbase-server generated 25 new + 1 unchanged - 0 fixed = 26 total (was 1)
-0 ⚠️ javadoc 2m 57s root generated 25 new + 16 unchanged - 0 fixed = 41 total (was 16)
_ Other Tests _
+1 💚 unit 376m 52s root in the patch passed.
419m 9s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1834
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0b7fe01bbb1d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.3 / 39e03ab
Default Java 1.8.0_232
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/testReport/
Max. process+thread count 3420 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 11s root in branch-2.3 failed.
-1 ❌ compile 0m 9s root in branch-2.3 failed.
-1 ❌ shadedjars 0m 7s branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s root in branch-2.3 failed.
-0 ⚠️ javadoc 0m 15s hbase-common in branch-2.3 failed.
-0 ⚠️ javadoc 0m 23s hbase-server in branch-2.3 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 9s root in the patch failed.
-1 ❌ compile 0m 9s root in the patch failed.
-0 ⚠️ javac 0m 9s root in the patch failed.
-1 ❌ shadedjars 0m 7s patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s root in the patch failed.
-0 ⚠️ javadoc 0m 9s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 8s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 9s root in the patch failed.
4m 30s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1834
Optional Tests javac javadoc unit shadedjars compile
uname Linux cd3be25eb21a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.3 / 6ffa36b
Default Java 2020-01-14
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/testReport/
Max. process+thread count 56 (vs. ulimit of 12500)
modules C: . hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.3 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 47s branch-2.3 passed
+1 💚 checkstyle 2m 28s branch-2.3 passed
+0 🆗 refguide 11m 42s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 11m 40s branch-2.3 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 checkstyle 2m 27s root: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+0 🆗 refguide 7m 7s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 18m 16s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚 spotbugs 12m 12s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
82m 39s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1834
Optional Tests dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname Linux b02ec0d95c0d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.3 / 6ffa36b
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 122 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 24s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 53s branch-2.3 passed
+1 💚 compile 2m 22s branch-2.3 passed
+1 💚 shadedjars 5m 26s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 11s branch-2.3 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 2m 20s the patch passed
+1 💚 javac 2m 20s the patch passed
+1 💚 shadedjars 5m 28s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 35s hbase-server generated 25 new + 1 unchanged - 0 fixed = 26 total (was 1)
-0 ⚠️ javadoc 2m 24s root generated 25 new + 16 unchanged - 0 fixed = 41 total (was 16)
_ Other Tests _
+1 💚 unit 386m 11s root in the patch passed.
419m 27s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1834
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7ccefd3fcb07 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.3 / 6ffa36b
Default Java 1.8.0_232
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/testReport/
Max. process+thread count 3399 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
HBASE-24418 Consolidate Normalizer implementations
4b33916 
Simplify our Normalizer story to have just a single, configurable
implementation.

* fold the features of `MergeNormalizer` into
  `SimpleRegionNormalizer`, removing the intermediate abstract class.
* configuration keys for merge-only features now share a common
  structure.
* add configuration to selectively disable normalizer split/merge
  operations.
* `RegionNormalizer` now extends `Configurable` instead of creating a
  new instance of `HBaseConfiguration` or snooping one off of other
  fields.
* avoid the extra RPCs by using `MasterServices` instead of
  `MasterRpcServices`.
* boost test coverage of all the various flags and feature
  combinations.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: huaxiangsun <huaxiangsun@apache.org>
@ndimiduk ndimiduk force-pushed the 24418-consolidate-normalizer-branch-2.3 branch from 7acf321 to 4b33916 Compare June 3, 2020 23:41
@ndimiduk ndimiduk merged commit df79082 into apache:branch-2.3 Jun 3, 2020
@ndimiduk ndimiduk deleted the 24418-consolidate-normalizer-branch-2.3 branch June 3, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ndimiduk @Apache-HBase