-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME #1847
HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME #1847
Conversation
PTAL @joshelser @stoty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Testing with #1833 |
JDK11 Hadoop3 passed over on my PR. Merging this. |
Signed-off-by: Josh Elser <elserj@apache.org>
8a7246d
to
b001cf4
Compare
wtf GitHub made a merge commit? |
…HANGE_TARGET-branch-2" This reverts commit f66c80b.
…TARGET-branch-2" This reverts commit f66c80b.
Thanks Nick! |
…RGET-branch-2 HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
…HANGE_TARGET-branch-2" This reverts commit f66c80b.
Looks like we have two different environments with two sets of environment variables. Yetus talks about that target branch as
BRANCH_NAME
, but GitHub + Jenkins refer to it asCHANGE_TARGET
, so we need to use that one from the shell script that invokes Yetus.