Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME #1847

Merged

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 3, 2020

Looks like we have two different environments with two sets of environment variables. Yetus talks about that target branch as BRANCH_NAME, but GitHub + Jenkins refer to it as CHANGE_TARGET, so we need to use that one from the shell script that invokes Yetus.

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 3, 2020

PTAL @joshelser @stoty

@joshelser joshelser self-requested a review June 3, 2020 18:03
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
2m 13s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1847
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux e6fc89e1a762 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 8c9c670
Max. process+thread count 47 (vs. ulimit of 12500)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
_ Other Tests _
2m 36s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1847
Optional Tests
uname Linux f96e998fab0c 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 8c9c670
Max. process+thread count 51 (vs. ulimit of 12500)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 27s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
_ Other Tests _
3m 56s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1847
Optional Tests
uname Linux b7cdb95c96ac 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 8c9c670
Max. process+thread count 46 (vs. ulimit of 12500)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 3, 2020

Testing with #1833

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 3, 2020

JDK11 Hadoop3 passed over on my PR. Merging this.

Signed-off-by: Josh Elser <elserj@apache.org>
@ndimiduk ndimiduk force-pushed the 24280-addendum-CHANGE_TARGET-branch-2 branch from 8a7246d to b001cf4 Compare June 3, 2020 23:20
@ndimiduk ndimiduk merged commit f66c80b into apache:branch-2 Jun 3, 2020
@ndimiduk ndimiduk deleted the 24280-addendum-CHANGE_TARGET-branch-2 branch June 3, 2020 23:26
@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 3, 2020

wtf GitHub made a merge commit?

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jun 3, 2020
ndimiduk added a commit that referenced this pull request Jun 3, 2020
@joshelser
Copy link
Member

Thanks Nick!

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
…RGET-branch-2

HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants