Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2 #1833

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2 #1833

merged 1 commit into from
Jun 3, 2020

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 2, 2020

Simplify our Normalizer story to have just a single, configurable
implementation.

  • fold the features of MergeNormalizer into
    SimpleRegionNormalizer, removing the intermediate abstract class.
  • configuration keys for merge-only features now share a common
    structure.
  • add configuration to selectively disable normalizer split/merge
    operations.
  • RegionNormalizer now extends Configurable instead of creating a
    new instance of HBaseConfiguration or snooping one off of other
    fields.
  • avoid the extra RPCs by using MasterServices instead of
    MasterRpcServices.
  • boost test coverage of all the various flags and feature
    combinations.

Signed-off-by: Michael Stack stack@apache.org
Signed-off-by: Viraj Jasani vjasani@apache.org
Signed-off-by: huaxiangsun huaxiangsun@apache.org

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 54s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 15s root in branch-2 failed.
-1 ❌ compile 0m 10s root in branch-2 failed.
-1 ❌ shadedjars 0m 9s branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 11s root in branch-2 failed.
-0 ⚠️ javadoc 0m 16s hbase-common in branch-2 failed.
-0 ⚠️ javadoc 0m 27s hbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 9s root in the patch failed.
-1 ❌ compile 0m 10s root in the patch failed.
-0 ⚠️ javac 0m 10s root in the patch failed.
-1 ❌ shadedjars 0m 7s patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 11s root in the patch failed.
-0 ⚠️ javadoc 0m 9s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 8s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 10s root in the patch failed.
5m 24s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1833
Optional Tests javac javadoc unit shadedjars compile
uname Linux fd07066d6503 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 9c8895c
Default Java 2020-01-14
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/testReport/
Max. process+thread count 48 (vs. ulimit of 12500)
modules C: . hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 30s branch-2 passed
+1 💚 checkstyle 2m 5s branch-2 passed
+0 🆗 refguide 11m 18s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 10m 21s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 9s the patch passed
+1 💚 checkstyle 2m 5s root: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+0 🆗 refguide 6m 36s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 11m 24s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 10m 48s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
71m 5s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1833
Optional Tests dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 15ded1962578 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 9c8895c
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 137 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Jun 2, 2020

JDK11 builds locally without issue. Nothing undue in the yetus setup of docker images...

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 12s root in branch-2 failed.
-1 ❌ compile 0m 9s root in branch-2 failed.
-1 ❌ shadedjars 0m 8s branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s root in branch-2 failed.
-0 ⚠️ javadoc 0m 14s hbase-common in branch-2 failed.
-0 ⚠️ javadoc 0m 22s hbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 9s root in the patch failed.
-1 ❌ compile 0m 9s root in the patch failed.
-0 ⚠️ javac 0m 9s root in the patch failed.
-1 ❌ shadedjars 0m 8s patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s root in the patch failed.
-0 ⚠️ javadoc 0m 8s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 9s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 9s root in the patch failed.
4m 39s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1833
Optional Tests javac javadoc unit shadedjars compile
uname Linux fcc359cc701a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 11d093b
Default Java 2020-01-14
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/testReport/
Max. process+thread count 55 (vs. ulimit of 12500)
modules C: . hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s branch-2 passed
+1 💚 checkstyle 2m 34s branch-2 passed
+0 🆗 refguide 13m 25s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 14m 17s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 8s the patch passed
+1 💚 checkstyle 2m 21s root: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+0 🆗 refguide 6m 42s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 11m 25s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 10m 56s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
80m 16s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1833
Optional Tests dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname Linux aa9ceb694513 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 11d093b
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 138 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk force-pushed the 24418-consolidate-normalizer-branch-2 branch from bc0e12e to 36a6b12 Compare June 3, 2020 18:36
@ndimiduk ndimiduk mentioned this pull request Jun 3, 2020
Merged
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 14s branch-2 passed
+1 💚 checkstyle 2m 38s branch-2 passed
+0 🆗 refguide 12m 5s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 12m 29s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 checkstyle 2m 40s root: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+0 🆗 refguide 7m 19s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 12m 30s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 12m 43s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
82m 10s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1833
Optional Tests dupname asflicense shellcheck shelldocs refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname Linux a70fbec69cb0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 8c9c670
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 122 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 37s branch-2 passed
+1 💚 compile 3m 0s branch-2 passed
+1 💚 shadedjars 6m 28s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s root in branch-2 failed.
-0 ⚠️ javadoc 0m 16s hbase-common in branch-2 failed.
-0 ⚠️ javadoc 0m 39s hbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 16s the patch passed
+1 💚 compile 2m 56s the patch passed
+1 💚 javac 2m 56s the patch passed
+1 💚 shadedjars 6m 27s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 15s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 14s root in the patch failed.
_ Other Tests _
+1 💚 unit 224m 31s root in the patch passed.
258m 48s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1833
Optional Tests javac javadoc unit shadedjars compile
uname Linux ee8e6fe70eeb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 8c9c670
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/testReport/
Max. process+thread count 6084 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
HBASE-24418 Consolidate Normalizer implementations
78a5396 
Simplify our Normalizer story to have just a single, configurable
implementation.

* fold the features of `MergeNormalizer` into
  `SimpleRegionNormalizer`, removing the intermediate abstract class.
* configuration keys for merge-only features now share a common
  structure.
* add configuration to selectively disable normalizer split/merge
  operations.
* `RegionNormalizer` now extends `Configurable` instead of creating a
  new instance of `HBaseConfiguration` or snooping one off of other
  fields.
* avoid the extra RPCs by using `MasterServices` instead of
  `MasterRpcServices`.
* boost test coverage of all the various flags and feature
  combinations.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: huaxiangsun <huaxiangsun@apache.org>
@ndimiduk ndimiduk force-pushed the 24418-consolidate-normalizer-branch-2 branch from 36a6b12 to 78a5396 Compare June 3, 2020 23:41
@ndimiduk ndimiduk merged commit 4884773 into apache:branch-2 Jun 3, 2020
@ndimiduk ndimiduk deleted the 24418-consolidate-normalizer-branch-2 branch June 3, 2020 23:43
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 30s branch-2 passed
+1 💚 compile 2m 8s branch-2 passed
+1 💚 shadedjars 5m 7s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 3s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 9s the patch passed
+1 💚 compile 2m 11s the patch passed
+1 💚 javac 2m 11s the patch passed
+1 💚 shadedjars 5m 2s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 35s hbase-server generated 25 new + 1 unchanged - 0 fixed = 26 total (was 1)
-0 ⚠️ javadoc 2m 5s root generated 25 new + 16 unchanged - 0 fixed = 41 total (was 16)
_ Other Tests _
-1 ❌ unit 290m 14s root in the patch failed.
321m 25s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1833
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1aab68483977 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 8c9c670
Default Java 1.8.0_232
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/testReport/
Max. process+thread count 7494 (vs. ulimit of 12500)
modules C: hbase-common hbase-server . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ndimiduk @Apache-HBase