HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing … #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Jun 10, 2020
| @@ -622,7 +622,8 @@ void setDataBlockEncoderInTest(HFileDataBlockEncoder blockEncoder) { | |||
| for (HStoreFile storeFile : results) { | |||
| if (compactedStoreFiles.contains(storeFile.getPath().getName())) { | |||
| LOG.warn("Clearing the compacted storefile {} from {}", storeFile, this); | |||
| storeFile.getReader().close(true); | |||
| storeFile.getReader().close(storeFile.getCacheConf() != null ? | |||
There was a problem hiding this comment.
While closing the region, doing the evict caused delay in closure. But here are we seeing some impact because of this evict? This will happen in async way from the Discharger thread right? Just trying to understand.
There was a problem hiding this comment.
Thank you for reviewing this!
Yes, this will happen in async way from the Discharger thread. So looks like we don't need to change this line. I will revert this change. Thanks.
There was a problem hiding this comment.
Checking again.. Sorry my bad. I wanted to add this at other place but ended up here. This is a call happening during region open. So you might want to keep ur change here.
There was a problem hiding this comment.
Oh okay. I missed that, too.. Thank you for pointing it out.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Jun 11, 2020
| @@ -2741,7 +2741,8 @@ private void removeCompactedfiles(Collection<HStoreFile> compactedfiles) | |||
| LOG.trace("Closing and archiving the file {}", file); | |||
| // Copy the file size before closing the reader | |||
| final long length = r.length(); | |||
| r.close(true); | |||
| r.close(file.getCacheConf() != null ? | |||
There was a problem hiding this comment.
This area will be getting called when we close a store as well as when the CompactionDischarger finds unreferenced compacted files.. CompactionDischarger is working in an async way anyways. But ya as per ur explanation, during close() we wanted to keep it this was as in patch.
There was a problem hiding this comment.
Sorry I was not clear in above comment. My ask was this.
This is called from closeAndArchiveCompactedFiles() and HStore#close().
The former is called in an async way by the Discharger thread anyways. When this area is called by that flow, we can preserve what is there today (Passing true). Close time ya lets honor the config. Sounds ok?
Ideally speaking we should have handled whole these in another way. Within the Cache implementation, the evict by hfile would have been an async impl. So the caller wont get blocked. But ya lets handle that in another jira.
There was a problem hiding this comment.
Thank you for the clarification. I understood that. Will change the patch according to your review. Thanks.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…compacted files and closing the storefiles
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
approved these changes
Jun 12, 2020
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jun 12, 2020
…compacted files and closing the storefiles (#1881) Signed-off-by: Anoop Sam John <anoop.hbase@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Jun 12, 2020
…compacted files and closing the storefiles (#1881) Signed-off-by: Anoop Sam John <anoop.hbase@gmail.com>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…compacted files and closing the storefiles (apache#1881) Signed-off-by: Anoop Sam John <anoop.hbase@gmail.com>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…compacted files and closing the storefiles (apache#1881) Signed-off-by: Anoop Sam John <anoop.hbase@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…compacted files and closing the storefiles