Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup #1936

Closed
wants to merge 1 commit into from
Closed

HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup #1936

wants to merge 1 commit into from

Conversation

sandeepvinayak
Copy link
Contributor

No description provided.

@sandeepvinayak
Copy link
Contributor Author

@Apache9

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 0m 24s master passed
+1 💚 shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 0m 27s the patch passed
+1 💚 javac 0m 27s the patch passed
+1 💚 shadedjars 6m 8s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 53s hbase-it in the patch passed.
24m 3s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1936
JIRA Issue HBASE-23126
Optional Tests javac javadoc unit shadedjars compile
uname Linux 01c6f3894954 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3c31981
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/testReport/
Max. process+thread count 657 (vs. ulimit of 12500)
modules C: hbase-it U: hbase-it
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 4s master passed
+1 💚 compile 0m 32s master passed
+1 💚 shadedjars 6m 31s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 17s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 37s the patch passed
+1 💚 compile 0m 32s the patch passed
+1 💚 javac 0m 32s the patch passed
+1 💚 shadedjars 6m 29s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 0m 51s hbase-it in the patch passed.
26m 32s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1936
JIRA Issue HBASE-23126
Optional Tests javac javadoc unit shadedjars compile
uname Linux dc8e030d64ea 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3c31981
Default Java 2020-01-14
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/testReport/
Max. process+thread count 661 (vs. ulimit of 12500)
modules C: hbase-it U: hbase-it
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 57s master passed
+1 💚 checkstyle 0m 18s master passed
+1 💚 spotbugs 0m 0s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 49s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 0s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
27m 55s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1936
JIRA Issue HBASE-23126
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 6b63360405e5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3c31981
Max. process+thread count 78 (vs. ulimit of 12500)
modules C: hbase-it U: hbase-it
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Jun 20, 2020
View reviewed changes
hbase-it/src/test/java/org/apache/hadoop/hbase/rsgroup/IntegrationTestRSGroup.java
afterMethod();
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should add a @Test method (maybe empty for now) to run @Before and @After because no test is present for quite some time and hence before and after is also not getting executed.
Anyways, @Apache9 will have better suggestions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it was used for running many integration tests which now have been split well and this became useless.

@virajjasani virajjasani requested a review from Apache9 June 20, 2020 07:33
Apache9
Apache9 approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better if someone could reimplement this test but since it is useless and no one provides a patch until now, let's remove it.
Can add back later when someone has a new patch for it.
+1.

virajjasani
virajjasani approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure if it is not being used, we can remove now and have it back when we have tests.
+1

virajjasani pushed a commit that referenced this pull request Jun 20, 2020
@sandeepvinayak @virajjasani
HBASE-23126: Removing the un-used integration test class - Integratio…
0527c2c 
…nTestRSGroup

Closes #1936

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@sandeepvinayak @clarax
HBASE-23126: Removing the un-used integration test class - Integratio…
76b752f 
…nTestRSGroup

Closes apache#1936

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

@Apache9 Apache9 Apache9 approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sandeepvinayak @Apache-HBase @HorizonNet @Apache9 @virajjasani