Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24598 : Backport HBASE-24380 (Provide WAL splitting journal logging) (#1860) #1937

Merged
merged 3 commits into from
Jun 21, 2020
Merged

HBASE-24598 : Backport HBASE-24380 (Provide WAL splitting journal logging) (#1860) #1937

merged 3 commits into from
Jun 21, 2020

Conversation

virajjasani
Copy link
Contributor

Signed-off-by: Andrew Purtell apurtell@apache.org

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 38s branch-2.2 passed
+1 💚 compile 0m 59s branch-2.2 passed
+1 💚 checkstyle 1m 31s branch-2.2 passed
+1 💚 shadedjars 4m 26s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2.2 passed
+0 🆗 spotbugs 3m 27s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 26s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 13s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
-1 ❌ checkstyle 1m 30s hbase-server: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 27m 41s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 36s the patch passed
+1 💚 findbugs 3m 38s the patch passed
_ Other Tests _
-1 ❌ unit 254m 13s hbase-server in the patch failed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
325m 49s
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/1/artifact/out/Dockerfile
GITHUB PR #1937
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d2215a99ab11 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1937/out/precommit/personality/provided.sh
git revision branch-2.2 / 4d3f8d1
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/1/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/1/testReport/
Max. process+thread count 3864 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani changed the title HBASE-24380 : Provide WAL splitting journal logging (#1860) HBASE-24598 : Backport HBASE-24380 (Provide WAL splitting journal logging) (#1860) Jun 20, 2020
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 11s branch-2.2 passed
+1 💚 compile 0m 58s branch-2.2 passed
+1 💚 checkstyle 1m 19s branch-2.2 passed
+1 💚 shadedjars 4m 2s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2.2 passed
+0 🆗 spotbugs 3m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 14s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 44s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 checkstyle 1m 19s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 25m 20s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 35s the patch passed
+1 💚 findbugs 3m 21s the patch passed
_ Other Tests _
+1 💚 unit 168m 9s hbase-server in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
232m 44s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/2/artifact/out/Dockerfile
GITHUB PR #1937
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3d0936744c65 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1937/out/precommit/personality/provided.sh
git revision branch-2.2 / 4d3f8d1
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/2/testReport/
Max. process+thread count 4669 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1937/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@infraio infraio added the backport This PR is a back port of some issue or issues already committed to master label Jun 21, 2020
infraio
infraio approved these changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani merged commit d154c79 into apache:branch-2.2 Jun 21, 2020
@virajjasani
Copy link
Contributor Author

Thanks for the review @infraio

@virajjasani virajjasani deleted the HBASE-24598-branch-2.2 branch June 21, 2020 10:43
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@virajjasani
HBASE-24598 : Backport HBASE-24380 (Provide WAL splitting journal log…
02468f3 
…ging) (apache#1860) (apache#1937)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit d154c79)

Change-Id: I4c1c975d3408005a76072ab971c0a5c1217f47cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infraio infraio infraio approved these changes

Assignees
No one assigned
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
3 participants
@virajjasani @Apache-HBase @infraio