HBASE-24646 Set the log level for ScheduledChore to INFO in HBTU #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Jun 27, 2020
| try (Table t = getConnection().getTable(TableName.META_TABLE_NAME); | ||
| ResultScanner s = t.getScanner(new Scan())) { | ||
| while (s.next() != null) { | ||
| continue; |
There was a problem hiding this comment.
continue is redundant, we can remove it and have just one comment stating this is empty loop. But this is not a strong opinion, only if you feel worth doing it :)
There was a problem hiding this comment.
Use a for(;;) to implement the logic. I'm afraid an empty {} will lead to a checkstyle warning.
There was a problem hiding this comment.
I like 'continue' instead of empty loop.
There was a problem hiding this comment.
... makes the intent clear.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Jun 28, 2020
asfgit
pushed a commit
that referenced
this pull request
Jun 28, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 28, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…che#1987) Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.