HBASE-24657 add unit test for JSONBean.java #2004

d-c-manning · 2020-06-30T22:44:31Z

A bug existed in JSONBean.java for branch-1. This PR migrates the test which covers the scenario into master. There is no product fix required other than in branch-1, PR for that fix is #1999.

I tried to keep the tests mostly in sync between branch-1 and master, but there are variations between branches which required changes.

Apache-HBase · 2020-06-30T23:19:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 20s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	5m 50s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-http in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 7s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
+1 💚	shadedjars	5m 45s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 17s	hbase-http in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 41s	hbase-http in the patch passed.
		23m 53s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2004
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0382012a5efc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be57e40`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/testReport/
Max. process+thread count	480 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-30T23:20:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	6m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	6m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 41s	hbase-http in the patch passed.
		25m 28s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2004
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f09d85d7b8c3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be57e40`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/testReport/
Max. process+thread count	394 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-30T23:25:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 57s	master passed
+1 💚	checkstyle	0m 17s	master passed
+1 💚	spotbugs	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	checkstyle	0m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 41s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		30m 14s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2004
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 489a7d491238 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be57e40`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-http/src/test/java/org/apache/hadoop/hbase/util/TestJSONBean.java

Apache-HBase · 2020-07-01T00:59:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	5m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 41s	hbase-http in the patch passed.
		21m 59s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2004
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7ef902e7ff9f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8c4d761`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/testReport/
Max. process+thread count	376 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-01T01:06:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	checkstyle	0m 16s	master passed
+1 💚	spotbugs	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 49s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		28m 55s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2004
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux c70738ffdbf8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8c4d761`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-01T01:12:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 29s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	7m 1s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 23s	hbase-http in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 3s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	6m 42s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-http in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 50s	hbase-http in the patch passed.
		29m 18s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2004
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aa75e6b0fe4a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8c4d761`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/testReport/
Max. process+thread count	409 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2004/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Closes #2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

Closes apache#2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

Closes apache#2004 Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit d1c3df8) Change-Id: I149ebda19e1c1b296a238194d4adf626c65f75fd

HBASE-24657 add unit test for JSONBean.java

6622ff8

d-c-manning mentioned this pull request Jun 30, 2020

HBASE-24657 fix JsonBean.java from HBASE-23015 HBASE-20571 #1999

Closed

Apache9 requested changes Jul 1, 2020

View reviewed changes

hbase-http/src/test/java/org/apache/hadoop/hbase/util/TestJSONBean.java Outdated Show resolved Hide resolved

GSON -> gson

a2048f4

virajjasani approved these changes Jul 1, 2020

View reviewed changes

virajjasani requested a review from Apache9 July 1, 2020 11:26

virajjasani closed this in e614b89 Jul 2, 2020

virajjasani pushed a commit that referenced this pull request Jul 2, 2020

HBASE-24657 add unit test for JSONBean.java

25e929b

Closes #2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani pushed a commit that referenced this pull request Jul 2, 2020

HBASE-24657 add unit test for JSONBean.java

0010fdc

Closes #2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani pushed a commit that referenced this pull request Jul 2, 2020

HBASE-24657 add unit test for JSONBean.java

d1c3df8

Closes #2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani pushed a commit that referenced this pull request Jul 2, 2020

HBASE-24657 add unit test for JSONBean.java

c91dbcc

Closes #2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24657 add unit test for JSONBean.java

59a6626

Closes apache#2004 Signed-off-by: Viraj Jasani <vjasani@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24657 add unit test for JSONBean.java #2004

HBASE-24657 add unit test for JSONBean.java #2004

d-c-manning commented Jun 30, 2020

Apache-HBase commented Jun 30, 2020

Apache-HBase commented Jun 30, 2020

Apache-HBase commented Jun 30, 2020

Apache-HBase commented Jul 1, 2020

Apache-HBase commented Jul 1, 2020

Apache-HBase commented Jul 1, 2020

virajjasani left a comment

HBASE-24657 add unit test for JSONBean.java #2004

HBASE-24657 add unit test for JSONBean.java #2004

Conversation

d-c-manning commented Jun 30, 2020

Apache-HBase commented Jun 30, 2020

Apache-HBase commented Jun 30, 2020

Apache-HBase commented Jun 30, 2020

Apache-HBase commented Jul 1, 2020

Apache-HBase commented Jul 1, 2020

Apache-HBase commented Jul 1, 2020

virajjasani left a comment

Choose a reason for hiding this comment