HBASE-24759 Refuse to update configuration of default group #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Aug 28, 2020
| @@ -592,7 +594,13 @@ private synchronized void refresh(boolean forceOnline) throws IOException { | |||
|
|
|||
| // This is added to the last of the list so it overwrites the 'default' rsgroup loaded | |||
| // from region group table or zk | |||
| groupList.add(new RSGroupInfo(RSGroupInfo.DEFAULT_GROUP, getDefaultServers(groupList))); | |||
There was a problem hiding this comment.
Why change this? getDefaultServers not used any more?
There was a problem hiding this comment.
getDefaultServers is still used in behind. This is just for version compatibility, not sure whether groupList has a default group or not after this patch.
infraio
reviewed
Aug 28, 2020
| return ProtobufUtil.toProtoGroupInfo(rsGroupInfo); | ||
| } else { | ||
| RSGroupInfo defaultGroupInfo = new RSGroupInfo(rsGroupInfo.getName()); | ||
| rsGroupInfo.getConfiguration().forEach(defaultGroupInfo::setConfiguration); |
There was a problem hiding this comment.
I didn't follow this. DEFAULT_GROUP don't need this?
There was a problem hiding this comment.
Yean, after HBASE-22820, we do not persist default group any more. So in this patch, just persist the configuration of default group. As for servers of default group, it is set while refresh().
ddupg
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Aug 30, 2020
| @@ -1270,6 +1270,9 @@ public synchronized void renameRSGroup(String oldName, String newName) throws IO | |||
| @Override | |||
| public synchronized void updateRSGroupConfig(String groupName, Map<String, String> configuration) | |||
| throws IOException { | |||
| if (RSGroupInfo.DEFAULT_GROUP.equals(groupName)) { | |||
| throw new ConstraintException(RSGroupInfo.DEFAULT_GROUP + " can't be stored persistently"); | |||
There was a problem hiding this comment.
Please add more comment here.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.